third_party/WebKit/Source/core/dom/DOMDataView.h - Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DOMDataView.h

Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tidy Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/DOMArrayPiece.cpp ('k') | third_party/WebKit/Source/core/dom/DOMDataView.cpp » ('j') | third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/DOMDataView.h

diff --git a/third_party/WebKit/Source/core/dom/DOMDataView.h b/third_party/WebKit/Source/core/dom/DOMDataView.h

index 2b54c4517fa029d5cf523f682c54a98dd6b21da9..f18d435d7fa2d095f95e762d9a41ecc1263d34f3 100644

--- a/third_party/WebKit/Source/core/dom/DOMDataView.h

+++ b/third_party/WebKit/Source/core/dom/DOMDataView.h

@@ -15,12 +15,12 @@ class CORE_EXPORT DOMDataView final : public DOMArrayBufferView {

public:

typedef char ValueType;

- static PassRefPtr<DOMDataView> create(PassRefPtr<DOMArrayBufferBase>, unsigned byteOffset, unsigned byteLength);

+ static DOMDataView* create(DOMArrayBufferBase*, unsigned byteOffset, unsigned byteLength);

v8::Local<v8::Object> wrap(v8::Isolate*, v8::Local<v8::Object> creationContext) override;

private:

- DOMDataView(PassRefPtr<WTF::ArrayBufferView> dataView, PassRefPtr<DOMArrayBufferBase> domArrayBuffer)

+ DOMDataView(PassRefPtr<WTF::ArrayBufferView> dataView, DOMArrayBufferBase* domArrayBuffer)

: DOMArrayBufferView(dataView, domArrayBuffer) { }

};