third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp - Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp

Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tidy Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/DOMArrayBuffer.h ('k') | third_party/WebKit/Source/core/dom/DOMArrayBufferBase.h » ('j') | third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp

diff --git a/third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp b/third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp

index a614c454e0e4d2bcc4a7fe9dd9f2440e4c766ff0..7f066c1004bf05d97ef17f32e5e56d9e12cab349 100644

--- a/third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp

+++ b/third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp

@@ -10,11 +10,6 @@ namespace blink {

v8::Local<v8::Object> DOMArrayBuffer::wrap(v8::Isolate* isolate, v8::Local<v8::Object> creationContext)

{

- // It's possible that no one except for the new wrapper owns this object at

- // this moment, so we have to prevent GC to collect this object until the

- // object gets associated with the wrapper.

- RefPtr<DOMArrayBuffer> protect(this);

DCHECK(!DOMDataStore::containsWrapper(this, isolate));

const WrapperTypeInfo* wrapperTypeInfo = this->wrapperTypeInfo();