Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/UnionTypesCore.h

Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tidy Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/UnionTypesCore.h
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/UnionTypesCore.h b/third_party/WebKit/Source/bindings/tests/results/core/UnionTypesCore.h
index 741b68601cc1be76c8d9aa8e5f1e9e160208ea6f..b8e794178dc310ea7d544491360b81b5a6c01085 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/UnionTypesCore.h
+++ b/third_party/WebKit/Source/bindings/tests/results/core/UnionTypesCore.h
@@ -33,14 +33,14 @@ public:
bool isNull() const { return m_type == SpecificTypeNone; }
bool isArrayBuffer() const { return m_type == SpecificTypeArrayBuffer; }
- PassRefPtr<TestArrayBuffer> getAsArrayBuffer() const;
- void setArrayBuffer(PassRefPtr<TestArrayBuffer>);
- static ArrayBufferOrArrayBufferViewOrDictionary fromArrayBuffer(PassRefPtr<TestArrayBuffer>);
+ TestArrayBuffer* getAsArrayBuffer() const;
+ void setArrayBuffer(TestArrayBuffer*);
+ static ArrayBufferOrArrayBufferViewOrDictionary fromArrayBuffer(TestArrayBuffer*);
bool isArrayBufferView() const { return m_type == SpecificTypeArrayBufferView; }
- PassRefPtr<TestArrayBufferView> getAsArrayBufferView() const;
- void setArrayBufferView(PassRefPtr<TestArrayBufferView>);
- static ArrayBufferOrArrayBufferViewOrDictionary fromArrayBufferView(PassRefPtr<TestArrayBufferView>);
+ TestArrayBufferView* getAsArrayBufferView() const;
+ void setArrayBufferView(TestArrayBufferView*);
+ static ArrayBufferOrArrayBufferViewOrDictionary fromArrayBufferView(TestArrayBufferView*);
bool isDictionary() const { return m_type == SpecificTypeDictionary; }
Dictionary getAsDictionary() const;
@@ -61,8 +61,8 @@ private:
};
SpecificTypes m_type;
- RefPtr<TestArrayBuffer> m_arrayBuffer;
- RefPtr<TestArrayBufferView> m_arrayBufferView;
+ Member<TestArrayBuffer> m_arrayBuffer;
+ Member<TestArrayBufferView> m_arrayBufferView;
Dictionary m_dictionary;
friend CORE_EXPORT v8::Local<v8::Value> toV8(const ArrayBufferOrArrayBufferViewOrDictionary&, v8::Local<v8::Object>, v8::Isolate*);
@@ -317,14 +317,14 @@ public:
static StringOrArrayBufferOrArrayBufferView fromString(String);
bool isArrayBuffer() const { return m_type == SpecificTypeArrayBuffer; }
- PassRefPtr<TestArrayBuffer> getAsArrayBuffer() const;
- void setArrayBuffer(PassRefPtr<TestArrayBuffer>);
- static StringOrArrayBufferOrArrayBufferView fromArrayBuffer(PassRefPtr<TestArrayBuffer>);
+ TestArrayBuffer* getAsArrayBuffer() const;
+ void setArrayBuffer(TestArrayBuffer*);
+ static StringOrArrayBufferOrArrayBufferView fromArrayBuffer(TestArrayBuffer*);
bool isArrayBufferView() const { return m_type == SpecificTypeArrayBufferView; }
- PassRefPtr<TestArrayBufferView> getAsArrayBufferView() const;
- void setArrayBufferView(PassRefPtr<TestArrayBufferView>);
- static StringOrArrayBufferOrArrayBufferView fromArrayBufferView(PassRefPtr<TestArrayBufferView>);
+ TestArrayBufferView* getAsArrayBufferView() const;
+ void setArrayBufferView(TestArrayBufferView*);
+ static StringOrArrayBufferOrArrayBufferView fromArrayBufferView(TestArrayBufferView*);
StringOrArrayBufferOrArrayBufferView(const StringOrArrayBufferOrArrayBufferView&);
~StringOrArrayBufferOrArrayBufferView();
@@ -341,8 +341,8 @@ private:
SpecificTypes m_type;
String m_string;
- RefPtr<TestArrayBuffer> m_arrayBuffer;
- RefPtr<TestArrayBufferView> m_arrayBufferView;
+ Member<TestArrayBuffer> m_arrayBuffer;
+ Member<TestArrayBufferView> m_arrayBufferView;
friend CORE_EXPORT v8::Local<v8::Value> toV8(const StringOrArrayBufferOrArrayBufferView&, v8::Local<v8::Object>, v8::Isolate*);
};
@@ -536,9 +536,9 @@ public:
static TestInterface2OrUint8Array fromTestInterface2(PassRefPtr<TestInterface2>);
bool isUint8Array() const { return m_type == SpecificTypeUint8Array; }
- PassRefPtr<DOMUint8Array> getAsUint8Array() const;
- void setUint8Array(PassRefPtr<DOMUint8Array>);
- static TestInterface2OrUint8Array fromUint8Array(PassRefPtr<DOMUint8Array>);
+ DOMUint8Array* getAsUint8Array() const;
+ void setUint8Array(DOMUint8Array*);
+ static TestInterface2OrUint8Array fromUint8Array(DOMUint8Array*);
TestInterface2OrUint8Array(const TestInterface2OrUint8Array&);
~TestInterface2OrUint8Array();
@@ -554,7 +554,7 @@ private:
SpecificTypes m_type;
RefPtr<TestInterface2> m_testInterface2;
- RefPtr<DOMUint8Array> m_uint8Array;
+ Member<DOMUint8Array> m_uint8Array;
friend CORE_EXPORT v8::Local<v8::Value> toV8(const TestInterface2OrUint8Array&, v8::Local<v8::Object>, v8::Isolate*);
};

Powered by Google App Engine
This is Rietveld 408576698