Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: third_party/WebKit/Source/core/dom/DOMArrayBufferView.h

Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tidy Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DOMArrayBufferView_h 5 #ifndef DOMArrayBufferView_h
6 #define DOMArrayBufferView_h 6 #define DOMArrayBufferView_h
7 7
8 #include "bindings/core/v8/ScriptWrappable.h" 8 #include "bindings/core/v8/ScriptWrappable.h"
9 #include "core/CoreExport.h" 9 #include "core/CoreExport.h"
10 #include "core/dom/DOMArrayBuffer.h" 10 #include "core/dom/DOMArrayBuffer.h"
11 #include "core/dom/DOMSharedArrayBuffer.h" 11 #include "core/dom/DOMSharedArrayBuffer.h"
12 #include "wtf/ArrayBufferView.h" 12 #include "wtf/ArrayBufferView.h"
13 #include "wtf/RefCounted.h"
14 13
15 namespace blink { 14 namespace blink {
16 15
17 class CORE_EXPORT DOMArrayBufferView : public RefCounted<DOMArrayBufferView>, pu blic ScriptWrappable { 16 class CORE_EXPORT DOMArrayBufferView : public GarbageCollectedFinalized<DOMArray BufferView>, public ScriptWrappable {
18 DEFINE_WRAPPERTYPEINFO(); 17 DEFINE_WRAPPERTYPEINFO();
19 public: 18 public:
20 typedef WTF::ArrayBufferView::ViewType ViewType; 19 typedef WTF::ArrayBufferView::ViewType ViewType;
21 static const ViewType TypeInt8 = WTF::ArrayBufferView::TypeInt8; 20 static const ViewType TypeInt8 = WTF::ArrayBufferView::TypeInt8;
22 static const ViewType TypeUint8 = WTF::ArrayBufferView::TypeUint8; 21 static const ViewType TypeUint8 = WTF::ArrayBufferView::TypeUint8;
23 static const ViewType TypeUint8Clamped = WTF::ArrayBufferView::TypeUint8Clam ped; 22 static const ViewType TypeUint8Clamped = WTF::ArrayBufferView::TypeUint8Clam ped;
24 static const ViewType TypeInt16 = WTF::ArrayBufferView::TypeInt16; 23 static const ViewType TypeInt16 = WTF::ArrayBufferView::TypeInt16;
25 static const ViewType TypeUint16 = WTF::ArrayBufferView::TypeUint16; 24 static const ViewType TypeUint16 = WTF::ArrayBufferView::TypeUint16;
26 static const ViewType TypeInt32 = WTF::ArrayBufferView::TypeInt32; 25 static const ViewType TypeInt32 = WTF::ArrayBufferView::TypeInt32;
27 static const ViewType TypeUint32 = WTF::ArrayBufferView::TypeUint32; 26 static const ViewType TypeUint32 = WTF::ArrayBufferView::TypeUint32;
28 static const ViewType TypeFloat32 = WTF::ArrayBufferView::TypeFloat32; 27 static const ViewType TypeFloat32 = WTF::ArrayBufferView::TypeFloat32;
29 static const ViewType TypeFloat64 = WTF::ArrayBufferView::TypeFloat64; 28 static const ViewType TypeFloat64 = WTF::ArrayBufferView::TypeFloat64;
30 static const ViewType TypeDataView = WTF::ArrayBufferView::TypeDataView; 29 static const ViewType TypeDataView = WTF::ArrayBufferView::TypeDataView;
31 30
32 virtual ~DOMArrayBufferView() { } 31 virtual ~DOMArrayBufferView() { }
33 32
34 PassRefPtr<DOMArrayBuffer> buffer() const 33 DOMArrayBuffer* buffer() const
35 { 34 {
36 DCHECK(!isShared()); 35 DCHECK(!isShared());
37 if (!m_domArrayBuffer) { 36 if (!m_domArrayBuffer)
38 m_domArrayBuffer = DOMArrayBuffer::create(view()->buffer()); 37 m_domArrayBuffer = DOMArrayBuffer::create(view()->buffer());
39 } 38
40 return static_pointer_cast<DOMArrayBuffer>(m_domArrayBuffer); 39 return static_cast<DOMArrayBuffer*>(m_domArrayBuffer.get());
41 } 40 }
42 41
43 PassRefPtr<DOMSharedArrayBuffer> bufferShared() const 42 DOMSharedArrayBuffer* bufferShared() const
44 { 43 {
45 DCHECK(isShared()); 44 DCHECK(isShared());
46 if (!m_domArrayBuffer) { 45 if (!m_domArrayBuffer)
47 m_domArrayBuffer = DOMSharedArrayBuffer::create(view()->buffer()); 46 m_domArrayBuffer = DOMSharedArrayBuffer::create(view()->buffer());
48 } 47
49 return static_pointer_cast<DOMSharedArrayBuffer>(m_domArrayBuffer); 48 return static_cast<DOMSharedArrayBuffer*>(m_domArrayBuffer.get());
50 } 49 }
51 50
52 PassRefPtr<DOMArrayBufferBase> bufferBase() const 51 DOMArrayBufferBase* bufferBase() const
53 { 52 {
54 if (isShared()) { 53 if (isShared())
55 return bufferShared(); 54 return bufferShared();
56 } 55
57 return buffer(); 56 return buffer();
58 } 57 }
59 58
60 const WTF::ArrayBufferView* view() const { return m_bufferView.get(); } 59 const WTF::ArrayBufferView* view() const { return m_bufferView.get(); }
61 WTF::ArrayBufferView* view() { return m_bufferView.get(); } 60 WTF::ArrayBufferView* view() { return m_bufferView.get(); }
62 61
63 ViewType type() const { return view()->type(); } 62 ViewType type() const { return view()->type(); }
64 const char* typeName() { return view()->typeName(); } 63 const char* typeName() { return view()->typeName(); }
65 void* baseAddress() const { return view()->baseAddress(); } 64 void* baseAddress() const { return view()->baseAddress(); }
66 unsigned byteOffset() const { return view()->byteOffset(); } 65 unsigned byteOffset() const { return view()->byteOffset(); }
67 unsigned byteLength() const { return view()->byteLength(); } 66 unsigned byteLength() const { return view()->byteLength(); }
68 void setNeuterable(bool flag) { return view()->setNeuterable(flag); } 67 void setNeuterable(bool flag) { return view()->setNeuterable(flag); }
69 bool isShared() const { return view()->isShared(); } 68 bool isShared() const { return view()->isShared(); }
70 69
71 v8::Local<v8::Object> wrap(v8::Isolate*, v8::Local<v8::Object> creationConte xt) override 70 v8::Local<v8::Object> wrap(v8::Isolate*, v8::Local<v8::Object> creationConte xt) override
72 { 71 {
73 ASSERT_NOT_REACHED(); 72 ASSERT_NOT_REACHED();
74 return v8::Local<v8::Object>(); 73 return v8::Local<v8::Object>();
75 } 74 }
76 75
76 DEFINE_INLINE_VIRTUAL_TRACE()
77 {
78 visitor->trace(m_domArrayBuffer);
79 }
80
77 protected: 81 protected:
78 explicit DOMArrayBufferView(PassRefPtr<WTF::ArrayBufferView> bufferView) 82 explicit DOMArrayBufferView(PassRefPtr<WTF::ArrayBufferView> bufferView)
79 : m_bufferView(bufferView) 83 : m_bufferView(bufferView)
80 { 84 {
81 DCHECK(m_bufferView); 85 DCHECK(m_bufferView);
82 } 86 }
83 DOMArrayBufferView(PassRefPtr<WTF::ArrayBufferView> bufferView, PassRefPtr<D OMArrayBufferBase> domArrayBuffer) 87 DOMArrayBufferView(PassRefPtr<WTF::ArrayBufferView> bufferView, DOMArrayBuff erBase* domArrayBuffer)
84 : m_bufferView(bufferView), m_domArrayBuffer(domArrayBuffer) 88 : m_bufferView(bufferView)
89 , m_domArrayBuffer(domArrayBuffer)
85 { 90 {
86 DCHECK(m_bufferView); 91 DCHECK(m_bufferView);
87 DCHECK(m_domArrayBuffer); 92 DCHECK(m_domArrayBuffer);
88 DCHECK_EQ(m_domArrayBuffer->buffer(), m_bufferView->buffer()); 93 DCHECK_EQ(m_domArrayBuffer->buffer(), m_bufferView->buffer());
89 } 94 }
90 95
91 private: 96 private:
92 RefPtr<WTF::ArrayBufferView> m_bufferView; 97 RefPtr<WTF::ArrayBufferView> m_bufferView;
93 mutable RefPtr<DOMArrayBufferBase> m_domArrayBuffer; 98 mutable Member<DOMArrayBufferBase> m_domArrayBuffer;
94 }; 99 };
95 100
96 } // namespace blink 101 } // namespace blink
97 102
98 #endif // DOMArrayBufferView_h 103 #endif // DOMArrayBufferView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698