Chromium Code Reviews| Index: tools/testing/dart/runtime_configuration.dart |
| diff --git a/tools/testing/dart/runtime_configuration.dart b/tools/testing/dart/runtime_configuration.dart |
| index fd30dd9931b165908781672498d332ab5ec5a407..3fa2ef345a51f2606db18b7667bbbce4cba866e9 100644 |
| --- a/tools/testing/dart/runtime_configuration.dart |
| +++ b/tools/testing/dart/runtime_configuration.dart |
| @@ -76,6 +76,8 @@ class RuntimeConfiguration { |
| // TODO(ahe): Make this method abstract. |
| throw "Unimplemented runtime '$runtimeType'"; |
| } |
| + |
| + List<String> dart2jsPreambles(Uri preambleDir) => []; |
|
kustermann
2014/03/06 09:56:49
It's strange that a RuntimeConfiguration knows abo
ahe
2014/03/06 10:21:09
Yes. It took Bill and I quite some time to find th
|
| } |
| /// The 'none' runtime configuration. |
| @@ -124,6 +126,10 @@ class D8RuntimeConfiguration extends CommandLineJavaScriptRuntime { |
| commandBuilder.getJSCommandlineCommand( |
| moniker, suite.d8FileName, arguments, environmentOverrides)]; |
| } |
| + |
| + List<String> dart2jsPreambles(Uri preambleDir) { |
| + return [preambleDir.resolve('d8.js').toFilePath()]; |
| + } |
| } |
| /// Firefox/SpiderMonkey-based development shell (jsshell). |
| @@ -142,6 +148,10 @@ class JsshellRuntimeConfiguration extends CommandLineJavaScriptRuntime { |
| commandBuilder.getJSCommandlineCommand( |
| moniker, suite.jsShellFileName, arguments, environmentOverrides)]; |
| } |
| + |
| + List<String> dart2jsPreambles(Uri preambleDir) { |
|
kustermann
2014/03/06 09:56:49
This method name is not correct. It doesn't return
ahe
2014/03/06 10:21:09
dart2jsPreambleArguments?
|
| + return ['-f', preambleDir.resolve('jsshell.js').toFilePath(), '-f']; |
| + } |
| } |
| /// Common runtime configuration for runtimes based on the Dart VM. |