Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1878393002: Emit warning when touchscreen association fails. (Closed)

Created:
4 years, 8 months ago by jdufault
Modified:
4 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Emit warning when touchscreen association fails. Useful to determine if a touchscreen not working is caused by touchscreen association or by some other issue when the device is not in devmode. BUG=600436 Committed: https://crrev.com/c0708c1da9664bd232e7870db74c8b8c59f4d3c1 Cr-Commit-Position: refs/heads/master@{#386796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ash/touch/touchscreen_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jdufault
Oshima, PTAL. This will let me figure out if the touchscreen bug in the description ...
4 years, 8 months ago (2016-04-12 19:35:28 UTC) #3
oshima
lgtm
4 years, 8 months ago (2016-04-12 19:55:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878393002/1
4 years, 8 months ago (2016-04-12 19:56:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 20:34:24 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 20:35:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0708c1da9664bd232e7870db74c8b8c59f4d3c1
Cr-Commit-Position: refs/heads/master@{#386796}

Powered by Google App Engine
This is Rietveld 408576698