Re-land: Add download_file_types.proto with ascii->binary conversion, as a resource.

Re-land: Add download_file_types.proto with ascii->binary conversion, as a resource.

This is a revert of the revert https://codereview.chromium.org/1881273002/

Added: Missing Python path, on some bots.

Orig desc: We'll maintain an ASCII version of the data in the repo, and build
the binary version as a Resource at build time.  The data will later be
updated at runtime.

BUG=596555
Committed: https://crrev.com/d6e8e6aaa8d07a0d576adbd2dafd0789b124660e
Cr-Commit-Position: refs/heads/master@{#387109}

[Nathan Parker, 2016-04-13 00:11:05]

Description was changed from

==========
Re-land: Add download_file_types.proto with ascii->binary conversion, as a
resource.

This is a revert of the revert: 6834929f54cd4dfbdd926ebb1f34edff98d32027

Added: Missing Python path, on some bots.

Orig desc: We'll maintain an ASCII version of the data in the repo, and build
the binary version as a Resource at build time.  The data will later be
updated at runtime.

BUG=596555
==========

to

==========
Re-land: Add download_file_types.proto with ascii->binary conversion, as a
resource.

This is a revert of the revert https://codereview.chromium.org/1881273002/

Added: Missing Python path, on some bots.

Orig desc: We'll maintain an ASCII version of the data in the repo, and build
the binary version as a Resource at build time.  The data will later be
updated at runtime.

BUG=596555
==========

[Nathan Parker, 2016-04-13 00:13:22]

nparker@chromium.org changed reviewers:
+ thestig@chromium.org

[Nathan Parker, 2016-04-13 00:13:23]

Patchset 1->2 is the only addition to the orig CL.  Thanks.

[Lei Zhang, 2016-04-13 01:16:07]

lgtm

https://codereview.chromium.org/1878383003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/safe_browsing/gen_file_type_proto.py (right):

https://codereview.chromium.org/1878383003/diff/20001/chrome/browser/resource...
chrome/browser/resources/safe_browsing/gen_file_type_proto.py:20: import
google.protobuf.text_format as text_format
Does the import order matter? If not, can we keep it alphabetical?

[Nathan Parker, 2016-04-13 17:41:29]

Thanks.

https://codereview.chromium.org/1878383003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/safe_browsing/gen_file_type_proto.py (right):

https://codereview.chromium.org/1878383003/diff/20001/chrome/browser/resource...
chrome/browser/resources/safe_browsing/gen_file_type_proto.py:20: import
google.protobuf.text_format as text_format
On 2016/04/13 01:16:07, Lei Zhang wrote:
> Does the import order matter? If not, can we keep it alphabetical?

Done.

[Nathan Parker, 2016-04-13 17:41:39]

The CQ bit was checked by nparker@chromium.org

[Nathan Parker, 2016-04-13 17:41:40]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1878383003/#ps40001
(title: "sorted import order")

[Nathan Parker, 2016-04-13 17:41:46]

The CQ bit was unchecked by nparker@chromium.org

[Nathan Parker, 2016-04-13 19:33:22]

The CQ bit was checked by nparker@chromium.org

[commit-bot: I haz the power, 2016-04-13 19:33:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878383003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878383003/40001

[commit-bot: I haz the power, 2016-04-13 19:45:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 19:45:38]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Nathan Parker, 2016-04-13 20:07:30]

The CQ bit was checked by nparker@chromium.org

[commit-bot: I haz the power, 2016-04-13 20:07:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878383003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878383003/40001

[commit-bot: I haz the power, 2016-04-13 20:26:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 20:26:26]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Nathan Parker, 2016-04-13 21:30:44]

android_chromium_gn_compile_rel bot is failing w/o the patch.

[Nathan Parker, 2016-04-13 21:33:01]

The CQ bit was checked by nparker@chromium.org

[commit-bot: I haz the power, 2016-04-13 21:33:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878383003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878383003/40001

[commit-bot: I haz the power, 2016-04-13 21:50:37]

Description was changed from

==========
Re-land: Add download_file_types.proto with ascii->binary conversion, as a
resource.

This is a revert of the revert https://codereview.chromium.org/1881273002/

Added: Missing Python path, on some bots.

Orig desc: We'll maintain an ASCII version of the data in the repo, and build
the binary version as a Resource at build time.  The data will later be
updated at runtime.

BUG=596555
==========

to

==========
Re-land: Add download_file_types.proto with ascii->binary conversion, as a
resource.

This is a revert of the revert https://codereview.chromium.org/1881273002/

Added: Missing Python path, on some bots.

Orig desc: We'll maintain an ASCII version of the data in the repo, and build
the binary version as a Resource at build time.  The data will later be
updated at runtime.

BUG=596555
==========

[commit-bot: I haz the power, 2016-04-13 21:50:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-13 21:52:17]

Description was changed from

==========
Re-land: Add download_file_types.proto with ascii->binary conversion, as a
resource.

This is a revert of the revert https://codereview.chromium.org/1881273002/

Added: Missing Python path, on some bots.

Orig desc: We'll maintain an ASCII version of the data in the repo, and build
the binary version as a Resource at build time.  The data will later be
updated at runtime.

BUG=596555
==========

to

==========
Re-land: Add download_file_types.proto with ascii->binary conversion, as a
resource.

This is a revert of the revert https://codereview.chromium.org/1881273002/

Added: Missing Python path, on some bots.

Orig desc: We'll maintain an ASCII version of the data in the repo, and build
the binary version as a Resource at build time.  The data will later be
updated at runtime.

BUG=596555

Committed: https://crrev.com/d6e8e6aaa8d07a0d576adbd2dafd0789b124660e
Cr-Commit-Position: refs/heads/master@{#387109}
==========

[commit-bot: I haz the power, 2016-04-13 21:52:18]

Patchset 3 (id:??) landed as
https://crrev.com/d6e8e6aaa8d07a0d576adbd2dafd0789b124660e
Cr-Commit-Position: refs/heads/master@{#387109}