Add GM to prevent mis-drawing of LCD text in SkPictureImageFilters

Add GM to prevent mis-drawing of LCD text in SkPictureImageFilters

BUG=602555
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1878373003

Committed: https://skia.googlesource.com/skia/+/54ef1a7c95bcc8e507f7d6ccd9a49bd9a110ba90

[robertphillips, 2016-04-13 16:24:40]

Description was changed from

==========
Add GM to prevent mis-drawing of LCD text in SkPictureImageFilters

BUG=602555
==========

to

==========
Add GM to prevent mis-drawing of LCD text in SkPictureImageFilters

BUG=602555
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-13 16:25:40]

Description was changed from

==========
Add GM to prevent mis-drawing of LCD text in SkPictureImageFilters

BUG=602555
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add GM to prevent mis-drawing of LCD text in SkPictureImageFilters

BUG=602555
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-13 16:25:40]

robertphillips@google.com changed reviewers:
+ senorblanco@chromium.org, senorblanco@google.com

[Stephen White, 2016-04-13 16:28:45]

On 2016/04/13 16:25:46, robertphillips wrote:

Thanks for this.

It may be tough to eyeball whether LCD text is on when triaging changes to this
GM. I wonder if it might be better to check for non-grayscale pixels in a unit
test instead?

Or alternatively, blow up (e.g., via an SkMatrixImageFilter or a second SkCanvas
pass) the rendered text in this GM to exaggerate any fringing?

[robertphillips, 2016-04-13 16:47:55]

On 2016/04/13 16:28:45, Stephen White wrote:
> On 2016/04/13 16:25:46, robertphillips wrote:
> 
> Thanks for this.
> 
> It may be tough to eyeball whether LCD text is on when triaging changes to
this
> GM. I wonder if it might be better to check for non-grayscale pixels in a unit
> test instead?
> 
> Or alternatively, blow up (e.g., via an SkMatrixImageFilter or a second
SkCanvas
> pass) the rendered text in this GM to exaggerate any fringing?

Done - I've used the PictureImageFilter's build in capability to make the result
larger.

[Stephen White, 2016-04-13 17:12:53]

On 2016/04/13 16:47:55, robertphillips wrote:
> On 2016/04/13 16:28:45, Stephen White wrote:
> > On 2016/04/13 16:25:46, robertphillips wrote:
> > 
> > Thanks for this.
> > 
> > It may be tough to eyeball whether LCD text is on when triaging changes to
> this
> > GM. I wonder if it might be better to check for non-grayscale pixels in a
unit
> > test instead?
> > 
> > Or alternatively, blow up (e.g., via an SkMatrixImageFilter or a second
> SkCanvas
> > pass) the rendered text in this GM to exaggerate any fringing?
> 
> Done - I've used the PictureImageFilter's build in capability to make the
result
> larger.

Good idea. LGTM

[robertphillips, 2016-04-13 17:43:18]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 17:43:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878373003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878373003/20001

[commit-bot: I haz the power, 2016-04-13 17:53:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 17:53:35]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-13 17:54:08]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-04-13 17:54:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878373003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878373003/20001

[commit-bot: I haz the power, 2016-04-13 17:55:10]

Description was changed from

==========
Add GM to prevent mis-drawing of LCD text in SkPictureImageFilters

BUG=602555
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add GM to prevent mis-drawing of LCD text in SkPictureImageFilters

BUG=602555
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/54ef1a7c95bcc8e507f7d6ccd9a49bd9a110ba90
==========

[commit-bot: I haz the power, 2016-04-13 17:55:10]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/54ef1a7c95bcc8e507f7d6ccd9a49bd9a110ba90