Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: tools/gn/loader.h

Issue 1878353002: GN: Use std::unique_ptr in Loader::ToolchainRecordMap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unnecessary WrapUnique Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/loader.h
diff --git a/tools/gn/loader.h b/tools/gn/loader.h
index 3d61fe4b4e867e005c686305d573100220304880..37f708563c49b73e4f3591c2aee8d46df89e6630 100644
--- a/tools/gn/loader.h
+++ b/tools/gn/loader.h
@@ -6,6 +6,7 @@
#define TOOLS_GN_LOADER_H_
#include <map>
+#include <memory>
#include <set>
#include "base/callback.h"
@@ -173,8 +174,7 @@ class LoaderImpl : public Loader {
Label default_toolchain_label_;
// Records for the build config file loads.
- // Owning pointers.
- typedef std::map<Label, ToolchainRecord*> ToolchainRecordMap;
+ typedef std::map<Label, std::unique_ptr<ToolchainRecord>> ToolchainRecordMap;
ToolchainRecordMap toolchain_records_;
};
« no previous file with comments | « no previous file | tools/gn/loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698