Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1878353002: GN: Use std::unique_ptr in Loader::ToolchainRecordMap. (Closed)

Created:
4 years, 8 months ago by jbroman
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Use std::unique_ptr in Loader::ToolchainRecordMap. BUG=602726 Committed: https://crrev.com/f9b6b5ae0cd8396663e5c1b06468384fc9d89688 Cr-Commit-Position: refs/heads/master@{#388015}

Patch Set 1 #

Patch Set 2 : remove unnecessary WrapUnique #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -21 lines) Patch
M tools/gn/loader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/loader.cc View 1 7 chunks +22 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878353002/20001
4 years, 8 months ago (2016-04-18 18:11:41 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 19:05:51 UTC) #4
jbroman
4 years, 8 months ago (2016-04-18 19:08:29 UTC) #7
brettw
lgtm
4 years, 8 months ago (2016-04-18 19:42:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878353002/20001
4 years, 8 months ago (2016-04-18 20:52:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 20:59:47 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 21:00:49 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f9b6b5ae0cd8396663e5c1b06468384fc9d89688
Cr-Commit-Position: refs/heads/master@{#388015}

Powered by Google App Engine
This is Rietveld 408576698