Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: Source/devtools/front_end/SplitView.js

Issue 187833006: DevTools: Bring back split view animation on show/hide sidebar button click. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 10 *
(...skipping 800 matching lines...) Expand 10 before | Expand all | Expand 10 after
811 this._updateShowHideSidebarButton(); 811 this._updateShowHideSidebarButton();
812 812
813 /** 813 /**
814 * @this {WebInspector.SplitView} 814 * @this {WebInspector.SplitView}
815 * @param {!WebInspector.Event} event 815 * @param {!WebInspector.Event} event
816 */ 816 */
817 function buttonClicked(event) 817 function buttonClicked(event)
818 { 818 {
819 var show = this._isShowingOne; 819 var show = this._isShowingOne;
820 if (show) 820 if (show)
821 this.showBoth(); 821 this.showBoth(true);
822 else 822 else
823 this.hideSidebar(); 823 this.hideSidebar(true);
824 } 824 }
825 825
826 return this._showHideSidebarButton; 826 return this._showHideSidebarButton;
827 }, 827 },
828 828
829 _updateShowHideSidebarButton: function() 829 _updateShowHideSidebarButton: function()
830 { 830 {
831 if (!this._showHideSidebarButton) 831 if (!this._showHideSidebarButton)
832 return; 832 return;
833 this._showHideSidebarButton.state = this._isShowingOne === this.isSideba rSecond() ? "left" : "right"; 833 this._showHideSidebarButton.state = this._isShowingOne === this.isSideba rSecond() ? "left" : "right";
834 this._showHideSidebarButton.title = this._isShowingOne ? WebInspector.UI String("Show %s", this._showHideSidebarButtonTitle) : WebInspector.UIString("Hid e %s", this._showHideSidebarButtonTitle); 834 this._showHideSidebarButton.title = this._isShowingOne ? WebInspector.UI String("Show %s", this._showHideSidebarButtonTitle) : WebInspector.UIString("Hid e %s", this._showHideSidebarButtonTitle);
835 }, 835 },
836 836
837 __proto__: WebInspector.View.prototype 837 __proto__: WebInspector.View.prototype
838 } 838 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698