Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 187833006: DevTools: Bring back split view animation on show/hide sidebar button click. (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Bring back split view animation on show/hide sidebar button click. R=dgozman@chromium.org, dgozman, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/devtools/front_end/SplitView.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsevik
PTAL
6 years, 9 months ago (2014-03-06 08:04:01 UTC) #1
dgozman
lgtm I wonder when this had gone away.
6 years, 9 months ago (2014-03-06 08:10:39 UTC) #2
vsevik
6 years, 9 months ago (2014-03-06 11:17:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r168623 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698