Remove URLencode/URLdecode for the inner origin of blob: URLs

Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome has always done things. However, it is not spec compliant, and blob URLs produced this way are not understood properly by GURL/url::Origin.

The new behavior makes Chrome consistent with Firefox, Safari, and https://w3c.github.io/FileAPI/#unicodeBlobURL

I believe this is safe change, because blob URLs have transient lifetimes, that never outlast a browsing session.

blink-dev "Intent to Implement/Ship" thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/zY4JH54zZhc/PJlsDr35BAAJ
BUG=561644, 603278
TBR=brettw@chromium.org

Committed: https://crrev.com/1b17dc30c89fc6a7a70a490ac942e853537fc2b9
Cr-Commit-Position: refs/heads/master@{#387703}

[ncarter (slow), 2016-04-12 21:07:40]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 21:08:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878273002/20001

[commit-bot: I haz the power, 2016-04-12 21:18:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 21:18:20]

Dry run: This issue passed the CQ dry run.

[ncarter (slow), 2016-04-12 21:39:45]

Description was changed from

==========
Remove URL encode/decode for blob URLs

BUG=561644
==========

to

==========
Remove URLencode/URLdecode for the inner URL of blob: scheme URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome/WebKit have always done things.
However, it is not spec compliant, and blob URLs produced this way are not
understood properly by GURL/url::Origin.

I believe this is safe, because blob URLs have transient lifetimes, that never
outlast a browsing session.

BUG=561644
==========

[ncarter (slow), 2016-04-13 17:42:54]

nick@chromium.org changed reviewers:
+ dmurph@chromium.org, michaeln@chromium.org, mkwst@chromium.org

[ncarter (slow), 2016-04-13 17:42:54]

I'd like to try pushing ahead with this. I think the security benefit of having
URLs that the browser process can parse will outweighs the risks.

[dmurph, 2016-04-13 17:47:49]

We should watch for bug reports after this is in, but I generally support this
change. Nothing that I've seen would suggest that this should break anything.
There urls are also not persisted in any way either (as blobs are temporary), so
there shouldn't be any migration problems.

[dmurph, 2016-04-13 17:47:57]

On 2016/04/13 at 17:47:49, dmurph wrote:
> We should watch for bug reports after this is in, but I generally support this
change. Nothing that I've seen would suggest that this should break anything.
There urls are also not persisted in any way either (as blobs are temporary), so
there shouldn't be any migration problems.

lgtm

[dmurph, 2016-04-13 17:47:58]

On 2016/04/13 at 17:47:49, dmurph wrote:
> We should watch for bug reports after this is in, but I generally support this
change. Nothing that I've seen would suggest that this should break anything.
There urls are also not persisted in any way either (as blobs are temporary), so
there shouldn't be any migration problems.

lgtm

[Mike West, 2016-04-13 18:12:58]

LGTM. Let's try it out. I'm sure we'll see some breakage, as this structure has
been in place for years, and I'm sure there are hardcoded dependencies and
strange parsers out there. Still, there's enough time before M52 to land it and
see what the feedback is like.

Please send an FYI to blink-dev@ announcing the change. I don't think this
requires an "Intent to Ship", but if folks there night think differently.

[michaeln, 2016-04-13 20:25:05]

lgtm 2

> LGTM. Let's try it out. I'm sure we'll see some breakage, as this structure
has
> been in place for years, and I'm sure there are hardcoded dependencies and
> strange parsers out there. Still, there's enough time before M52 to land it
and
> see what the feedback is like.
> 
> Please send an FYI to blink-dev@ announcing the change. I don't think this
> requires an "Intent to Ship", but if folks there night think differently.

[ncarter (slow), 2016-04-13 21:55:38]

Description was changed from

==========
Remove URLencode/URLdecode for the inner URL of blob: scheme URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome/WebKit have always done things.
However, it is not spec compliant, and blob URLs produced this way are not
understood properly by GURL/url::Origin.

I believe this is safe, because blob URLs have transient lifetimes, that never
outlast a browsing session.

BUG=561644
==========

to

==========
Remove URLencode/URLdecode for the inner URL of blob: scheme URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome/WebKit have always done things.
However, it is not spec compliant, and blob URLs produced this way are not
understood properly by GURL/url::Origin.

I believe this is safe, because blob URLs have transient lifetimes, that never
outlast a browsing session.

BUG=561644,603278
==========

[ncarter (slow), 2016-04-13 21:56:45]

Per dcheng's advice, I went ahead and posted an "Intent To Implement/Ship" to
blink-dev.

I'll hold off on landing this CL until I get a green light from there.

[ncarter (slow), 2016-04-13 21:57:39]

Description was changed from

==========
Remove URLencode/URLdecode for the inner URL of blob: scheme URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome/WebKit have always done things.
However, it is not spec compliant, and blob URLs produced this way are not
understood properly by GURL/url::Origin.

I believe this is safe, because blob URLs have transient lifetimes, that never
outlast a browsing session.

BUG=561644,603278
==========

to

==========
Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome/WebKit have always done things.
However, it is not spec compliant, and blob URLs produced this way are not
understood properly by GURL/url::Origin.

I believe this is safe, because blob URLs have transient lifetimes, that never
outlast a browsing session.

BUG=561644,603278
==========

[ncarter (slow), 2016-04-13 21:58:45]

Description was changed from

==========
Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome/WebKit have always done things.
However, it is not spec compliant, and blob URLs produced this way are not
understood properly by GURL/url::Origin.

I believe this is safe, because blob URLs have transient lifetimes, that never
outlast a browsing session.

BUG=561644,603278
==========

to

==========
Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome has always done things. However, it is
not spec compliant, and blob URLs produced this way are not understood properly
by GURL/url::Origin.

The new behavior makes Chrome consistent with Firefox, Safari, and 
https://w3c.github.io/FileAPI/#unicodeBlobURL

I believe this is safe, because blob URLs have transient lifetimes, that never
outlast a browsing session.

BUG=561644,603278
==========

[ncarter (slow), 2016-04-13 21:59:07]

Description was changed from

==========
Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome has always done things. However, it is
not spec compliant, and blob URLs produced this way are not understood properly
by GURL/url::Origin.

The new behavior makes Chrome consistent with Firefox, Safari, and 
https://w3c.github.io/FileAPI/#unicodeBlobURL

I believe this is safe, because blob URLs have transient lifetimes, that never
outlast a browsing session.

BUG=561644,603278
==========

to

==========
Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome has always done things. However, it is
not spec compliant, and blob URLs produced this way are not understood properly
by GURL/url::Origin.

The new behavior makes Chrome consistent with Firefox, Safari, and
https://w3c.github.io/FileAPI/#unicodeBlobURL

I believe this is safe change, because blob URLs have transient lifetimes, that
never outlast a browsing session.

BUG=561644,603278
==========

[ncarter (slow), 2016-04-14 18:15:31]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2016-04-14 18:16:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878273002/20001

[ncarter (slow), 2016-04-14 18:17:58]

Description was changed from

==========
Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome has always done things. However, it is
not spec compliant, and blob URLs produced this way are not understood properly
by GURL/url::Origin.

The new behavior makes Chrome consistent with Firefox, Safari, and
https://w3c.github.io/FileAPI/#unicodeBlobURL

I believe this is safe change, because blob URLs have transient lifetimes, that
never outlast a browsing session.

BUG=561644,603278
==========

to

==========
Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome has always done things. However, it is
not spec compliant, and blob URLs produced this way are not understood properly
by GURL/url::Origin.

The new behavior makes Chrome consistent with Firefox, Safari, and
https://w3c.github.io/FileAPI/#unicodeBlobURL

I believe this is safe change, because blob URLs have transient lifetimes, that
never outlast a browsing session.

blink "Intent to Implement/Ship" thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zY4JH54zZhc/PJlsDr35...
BUG=561644,603278
==========

[ncarter (slow), 2016-04-14 18:18:03]

The CQ bit was unchecked by nick@chromium.org

[ncarter (slow), 2016-04-14 18:21:20]

nick@chromium.org changed reviewers:
+ brettw@chromium.org

[ncarter (slow), 2016-04-14 18:21:21]

+brettw for stuff outside of blink

[ncarter (slow), 2016-04-14 18:22:09]

Description was changed from

==========
Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome has always done things. However, it is
not spec compliant, and blob URLs produced this way are not understood properly
by GURL/url::Origin.

The new behavior makes Chrome consistent with Firefox, Safari, and
https://w3c.github.io/FileAPI/#unicodeBlobURL

I believe this is safe change, because blob URLs have transient lifetimes, that
never outlast a browsing session.

blink "Intent to Implement/Ship" thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zY4JH54zZhc/PJlsDr35...
BUG=561644,603278
==========

to

==========
Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome has always done things. However, it is
not spec compliant, and blob URLs produced this way are not understood properly
by GURL/url::Origin.

The new behavior makes Chrome consistent with Firefox, Safari, and
https://w3c.github.io/FileAPI/#unicodeBlobURL

I believe this is safe change, because blob URLs have transient lifetimes, that
never outlast a browsing session.

blink-dev "Intent to Implement/Ship" thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zY4JH54zZhc/PJlsDr35...
BUG=561644,603278
==========

[ncarter (slow), 2016-04-15 20:01:22]

Description was changed from

==========
Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome has always done things. However, it is
not spec compliant, and blob URLs produced this way are not understood properly
by GURL/url::Origin.

The new behavior makes Chrome consistent with Firefox, Safari, and
https://w3c.github.io/FileAPI/#unicodeBlobURL

I believe this is safe change, because blob URLs have transient lifetimes, that
never outlast a browsing session.

blink-dev "Intent to Implement/Ship" thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zY4JH54zZhc/PJlsDr35...
BUG=561644,603278
==========

to

==========
Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome has always done things. However, it is
not spec compliant, and blob URLs produced this way are not understood properly
by GURL/url::Origin.

The new behavior makes Chrome consistent with Firefox, Safari, and
https://w3c.github.io/FileAPI/#unicodeBlobURL

I believe this is safe change, because blob URLs have transient lifetimes, that
never outlast a browsing session.

blink-dev "Intent to Implement/Ship" thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zY4JH54zZhc/PJlsDr35...
BUG=561644,603278
TBR=brettw@chromium.org
==========

[ncarter (slow), 2016-04-15 20:01:51]

TBRing brettw for the changes outside of blink, which are trivial.

[ncarter (slow), 2016-04-15 20:01:58]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2016-04-15 20:02:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878273002/20001

[commit-bot: I haz the power, 2016-04-15 21:34:16]

Description was changed from

==========
Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome has always done things. However, it is
not spec compliant, and blob URLs produced this way are not understood properly
by GURL/url::Origin.

The new behavior makes Chrome consistent with Firefox, Safari, and
https://w3c.github.io/FileAPI/#unicodeBlobURL

I believe this is safe change, because blob URLs have transient lifetimes, that
never outlast a browsing session.

blink-dev "Intent to Implement/Ship" thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zY4JH54zZhc/PJlsDr35...
BUG=561644,603278
TBR=brettw@chromium.org
==========

to

==========
Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome has always done things. However, it is
not spec compliant, and blob URLs produced this way are not understood properly
by GURL/url::Origin.

The new behavior makes Chrome consistent with Firefox, Safari, and
https://w3c.github.io/FileAPI/#unicodeBlobURL

I believe this is safe change, because blob URLs have transient lifetimes, that
never outlast a browsing session.

blink-dev "Intent to Implement/Ship" thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zY4JH54zZhc/PJlsDr35...
BUG=561644,603278
TBR=brettw@chromium.org
==========

[commit-bot: I haz the power, 2016-04-15 21:34:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-15 21:35:30]

Description was changed from

==========
Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome has always done things. However, it is
not spec compliant, and blob URLs produced this way are not understood properly
by GURL/url::Origin.

The new behavior makes Chrome consistent with Firefox, Safari, and
https://w3c.github.io/FileAPI/#unicodeBlobURL

I believe this is safe change, because blob URLs have transient lifetimes, that
never outlast a browsing session.

blink-dev "Intent to Implement/Ship" thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zY4JH54zZhc/PJlsDr35...
BUG=561644,603278
TBR=brettw@chromium.org
==========

to

==========
Remove URLencode/URLdecode for the inner origin of blob: URLs

This changes the value of "blob:" URLs from looking like this:
   blob:http%3A//localhost%3A8000/e80e38b8-cfe6-4b35-94c1-8519df140ede
To this:
   blob:http://localhost:8000/e80e38b8-cfe6-4b35-94c1-8519df140ede

The former case appears to be how Chrome has always done things. However, it is
not spec compliant, and blob URLs produced this way are not understood properly
by GURL/url::Origin.

The new behavior makes Chrome consistent with Firefox, Safari, and
https://w3c.github.io/FileAPI/#unicodeBlobURL

I believe this is safe change, because blob URLs have transient lifetimes, that
never outlast a browsing session.

blink-dev "Intent to Implement/Ship" thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zY4JH54zZhc/PJlsDr35...
BUG=561644,603278
TBR=brettw@chromium.org

Committed: https://crrev.com/1b17dc30c89fc6a7a70a490ac942e853537fc2b9
Cr-Commit-Position: refs/heads/master@{#387703}
==========

[commit-bot: I haz the power, 2016-04-15 21:35:31]

Patchset 2 (id:??) landed as
https://crrev.com/1b17dc30c89fc6a7a70a490ac942e853537fc2b9
Cr-Commit-Position: refs/heads/master@{#387703}

[brettw, 2016-04-18 17:08:19]

lgtm