Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1878263002: Unittests for signin_supervised_user_import_handler (Closed)

Created:
4 years, 8 months ago by Moe
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tfarina, pam+watch_chromium.org, Dan Beam, tommycli
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unittests for signin_supervised_user_import_handler BUG=563722 Committed: https://crrev.com/d78dcc0a1f3148b070b0ae80f4ccc8ac8a53c090 Cr-Commit-Position: refs/heads/master@{#387635}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed Roger's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -3 lines) Patch
M chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
A chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc View 1 1 chunk +263 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Moe
Hi Roger, please review this patch.
4 years, 8 months ago (2016-04-12 16:51:56 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/1878263002/diff/1/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc File chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc (right): https://codereview.chromium.org/1878263002/diff/1/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc#newcode103 chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc:103: kSupervisedUserAvatarName)); Nit: too much indentation.
4 years, 8 months ago (2016-04-15 14:08:10 UTC) #4
Moe
Thank you Roger! https://codereview.chromium.org/1878263002/diff/1/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc File chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc (right): https://codereview.chromium.org/1878263002/diff/1/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc#newcode103 chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc:103: kSupervisedUserAvatarName)); On 2016/04/15 14:08:10, Roger Tawa ...
4 years, 8 months ago (2016-04-15 15:40:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878263002/20001
4 years, 8 months ago (2016-04-15 17:34:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 17:41:56 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 17:45:16 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d78dcc0a1f3148b070b0ae80f4ccc8ac8a53c090
Cr-Commit-Position: refs/heads/master@{#387635}

Powered by Google App Engine
This is Rietveld 408576698