third_party/WebKit/Source/wtf/OwnPtr.h - Issue 1878253003: Allow explicit conversion operators and implement WTF::OwnPtr::operator bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/OwnPtr.h

Issue 1878253003: Allow explicit conversion operators and implement WTF::OwnPtr::operator bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.h ('k') | third_party/WebKit/Source/wtf/PassOwnPtr.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/wtf/OwnPtr.h

diff --git a/third_party/WebKit/Source/wtf/OwnPtr.h b/third_party/WebKit/Source/wtf/OwnPtr.h

index 0b0b58e081883b6b114a5ab04d6c8a17cf6d1f28..391031ca4c7d93c088c901d09990ba9f88cbaf18 100644

--- a/third_party/WebKit/Source/wtf/OwnPtr.h

+++ b/third_party/WebKit/Source/wtf/OwnPtr.h

@@ -70,11 +70,7 @@ public:

ValueType& operator[](std::ptrdiff_t i) const;

bool operator!() const { return !m_ptr; }

- // This conversion operator allows implicit conversion to bool but not to

- // other integer types.

- typedef PtrType OwnPtr::*UnspecifiedBoolType;

- operator UnspecifiedBoolType() const { return m_ptr ? &OwnPtr::m_ptr : 0; }

+ explicit operator bool() const { return m_ptr; }

OwnPtr& operator=(const PassOwnPtr<T>&);

OwnPtr& operator=(std::nullptr_t) { clear(); return *this; }