third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp - Issue 1878253003: Allow explicit conversion operators and implement WTF::OwnPtr::operator bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 1878253003: Allow explicit conversion operators and implement WTF::OwnPtr::operator bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h ('k') | third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

index fbc52502f6975d45a687607d728d440bdc28402c..9de6192b2f7700726df325ae75865767f1db9dab 100644

--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

@@ -948,7 +948,7 @@ void XMLHttpRequest::abort()

// |sendFlag| is only set when we have an active, asynchronous loader.

// Don't use it as "the send() flag" when the XHR is in sync mode.

- bool sendFlag = m_loader;

+ bool sendFlag = m_loader.get();

// internalAbort() clears the response. Save the data needed for

// dispatching ProgressEvents.

@@ -1025,7 +1025,7 @@ bool XMLHttpRequest::internalAbort()

// If abort() called internalAbort() and a nested open() ended up

// clearing the error flag, but didn't send(), make sure the error

// flag is still set.

- bool newLoadStarted = m_loader;

+ bool newLoadStarted = m_loader.get();

if (!newLoadStarted)

m_error = true;