third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp - Issue 1878253003: Allow explicit conversion operators and implement WTF::OwnPtr::operator bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

Issue 1878253003: Allow explicit conversion operators and implement WTF::OwnPtr::operator bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/InterpolationValue.h ('K') | « third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp » ('j') | third_party/WebKit/Source/wtf/OwnPtr.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

index c3666f29afcd29d958a2758febfe78996539eefd..a5145ca99b876c5271560dd0731fa9fc1107de7c 100644

--- a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

+++ b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

@@ -254,7 +254,7 @@ bool RecordingImageBufferSurface::finalizeFrameInternal(FallbackReason* fallback

m_previousFrame = fromSkSp(m_currentFrame->finishRecordingAsPicture());

initializeCurrentFrame();

}

- return m_currentFrame;

+ return !!m_currentFrame;

}

if (!m_frameWasCleared) {