third_party/WebKit/Source/core/fetch/FontResource.cpp - Issue 1878253003: Allow explicit conversion operators and implement WTF::OwnPtr::operator bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/FontResource.cpp

Issue 1878253003: Allow explicit conversion operators and implement WTF::OwnPtr::operator bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/InterpolationValue.h ('K') | « third_party/WebKit/Source/core/css/BinaryDataFontFaceSource.cpp ('k') | third_party/WebKit/Source/core/html/HTMLCanvasElement.h » ('j') | third_party/WebKit/Source/wtf/OwnPtr.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/FontResource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/FontResource.cpp b/third_party/WebKit/Source/core/fetch/FontResource.cpp

index 54a173f3deaeccc1dad10660d14b263a17859a6f..78ac50ff0ed99cc4252deedc778acf8f2d82ed66 100644

--- a/third_party/WebKit/Source/core/fetch/FontResource.cpp

+++ b/third_party/WebKit/Source/core/fetch/FontResource.cpp

@@ -147,7 +147,7 @@ bool FontResource::ensureCustomFontData()

recordPackageFormatHistogram(PackageFormatUnknown);

}

- return m_fontData;

+ return !!m_fontData;

}

FontPlatformData FontResource::platformDataFromCustomData(float size, bool bold, bool italic, FontOrientation orientation)