Adds support for remaining generic method syntax constructs.

Adds support for remaining generic method syntax constructs.

CL https://codereview.chromium.org/1863053003/ added support for most
syntactic constructs in relation to generic methods/functions, and
this one adds the missing ones: Declarations of function typed arguments
with type parameters, declarations of generic local functions, and
declarations of generic literal function expressions. It also adds
support for `super` bounds, because they were discussed recently and
may be quite useful (and it turns out to be no problem to parse them).
Finally, a new test file is added to tests the additional constructs.

BUG=
R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/377b806bbccbc969bb11b25c17c913e6df3dc31f

[eernst, 2016-04-12 16:29:28]

eernst@google.com changed reviewers:
+ johnniwinther@google.com

[eernst, 2016-04-12 16:29:29]

Parsing remaining generic method constructs.

Note the comments 'TODO(eernst): Check this, looks like an NPE with unbalanced
parens'. 

I added them because those locations look like they could cause null pointer
exceptions. However, if unbalanced parentheses are reported separately (before
the parser gets to run) then there is no problem. Those comments should then be
removed, along with a number of null checks.

[eernst, 2016-04-13 07:47:46]

Additional patch uploaded, with a comment at a location that looks like a bug,
explaining why it is actually OK.

[Johnni Winther, 2016-04-13 11:50:19]

https://codereview.chromium.org/1878253002/diff/20001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/parser.dart (right):

https://codereview.chromium.org/1878253002/diff/20001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser.dart:783: listener.endTypeVariable(token);
Remove 'handleExtendsOrSuper' and 'handleNoExtendsNorSuper' and pass and
'extendsOrSuperToken' to [endTypeVariable].

https://codereview.chromium.org/1878253002/diff/20001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser.dart:1856: // TODO(eernst): Check this, looks
like an NPE with unbalanced parens.
Do you have examples that trigger this (and others)?

[karlklose, 2016-04-13 12:26:54]

karlklose@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2016-04-13 12:26:55]

DBC:

https://codereview.chromium.org/1878253002/diff/20001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/parser.dart (right):

https://codereview.chromium.org/1878253002/diff/20001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser.dart:1855: Token endParen =
beginParen.endGroup;
Consider creating an issue for this and change the TODOs to use the issue
number. This way you know when you are done resolving these cases.

[eernst, 2016-04-13 17:08:26]

Response to review comments plus refactoring discussed IRL. Essentially, it's
about checking for '<', '{', '[' and using that information directly in several
small `parse..` methods, rather than dispatching on those tokens multiple times
and having a more complex `parseLiteralListOrMapOrFunction`.

We may wish to use a naming like `parse..Suffix` for `parseFields` and
`parseMethod` because they also rely on having a non-empty listener stack, but I
haven't done anything about that yet.

https://codereview.chromium.org/1878253002/diff/20001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/parser.dart (right):

https://codereview.chromium.org/1878253002/diff/20001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser.dart:783: listener.endTypeVariable(token);
On 2016/04/13 11:50:19, Johnni Winther wrote:
> Remove 'handleExtendsOrSuper' and 'handleNoExtendsNorSuper' and pass and
> 'extendsOrSuperToken' to [endTypeVariable].

Done.

https://codereview.chromium.org/1878253002/diff/20001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser.dart:1855: Token endParen =
beginParen.endGroup;
On 2016/04/13 12:26:55, karlklose wrote:
> Consider creating an issue for this and change the TODOs to use the issue
> number. This way you know when you are done resolving these cases.

Done.

https://codereview.chromium.org/1878253002/diff/20001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser.dart:1856: // TODO(eernst): Check this, looks
like an NPE with unbalanced parens.
On 2016/04/13 11:50:19, Johnni Winther wrote:
> Do you have examples that trigger this (and others)?

No, I hoped to get a quick confirmation like "That invariant can be trusted,
it's never null". But I'll clarify this in an upcoming CL, using the issue
number 26252 that I just created.

[Johnni Winther, 2016-04-14 08:23:50]

lgtm

https://codereview.chromium.org/1878253002/diff/40001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/parser.dart (right):

https://codereview.chromium.org/1878253002/diff/40001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser.dart:2265: Token beginToken = token;
You can assert that token is '[' or '[]' here.

https://codereview.chromium.org/1878253002/diff/40001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser.dart:2294: Token beginToken = token;
You can assert that token is '{' here.

https://codereview.chromium.org/1878253002/diff/40001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser.dart:2319: if (optional('(',token)) {
You can assert that token is '(' here.

[eernst, 2016-04-14 09:47:27]

Review response

https://codereview.chromium.org/1878253002/diff/40001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/parser.dart (right):

https://codereview.chromium.org/1878253002/diff/40001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser.dart:2265: Token beginToken = token;
On 2016/04/14 08:23:50, Johnni Winther wrote:
> You can assert that token is '[' or '[]' here.

Done.

https://codereview.chromium.org/1878253002/diff/40001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser.dart:2294: Token beginToken = token;
On 2016/04/14 08:23:50, Johnni Winther wrote:
> You can assert that token is '{' here.

Done.

https://codereview.chromium.org/1878253002/diff/40001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser.dart:2319: if (optional('(',token)) {
On 2016/04/14 08:23:50, Johnni Winther wrote:
> You can assert that token is '(' here.

Done.

[eernst, 2016-04-14 13:25:27]

Description was changed from

==========
Adds support for remaining generic method syntax constructs.

CL https://codereview.chromium.org/1863053003/ added support for most
syntactic constructs in relation to generic methods/functions, and
this one adds the missing ones: Declarations of function typed arguments
with type parameters, declarations of generic local functions, and
declarations of generic literal function expressions. It also adds
support for `super` bounds, because they were discussed recently and
may be quite useful (and it turns out to be no problem to parse them).
Finally, a new test file is added to tests the additional constructs.
==========

to

==========
Adds support for remaining generic method syntax constructs.

CL https://codereview.chromium.org/1863053003/ added support for most
syntactic constructs in relation to generic methods/functions, and
this one adds the missing ones: Declarations of function typed arguments
with type parameters, declarations of generic local functions, and
declarations of generic literal function expressions. It also adds
support for `super` bounds, because they were discussed recently and
may be quite useful (and it turns out to be no problem to parse them).
Finally, a new test file is added to tests the additional constructs.

BUG=
==========

[eernst, 2016-04-14 13:25:54]

Description was changed from

==========
Adds support for remaining generic method syntax constructs.

CL https://codereview.chromium.org/1863053003/ added support for most
syntactic constructs in relation to generic methods/functions, and
this one adds the missing ones: Declarations of function typed arguments
with type parameters, declarations of generic local functions, and
declarations of generic literal function expressions. It also adds
support for `super` bounds, because they were discussed recently and
may be quite useful (and it turns out to be no problem to parse them).
Finally, a new test file is added to tests the additional constructs.

BUG=
==========

to

==========
Adds support for remaining generic method syntax constructs.

CL https://codereview.chromium.org/1863053003/ added support for most
syntactic constructs in relation to generic methods/functions, and
this one adds the missing ones: Declarations of function typed arguments
with type parameters, declarations of generic local functions, and
declarations of generic literal function expressions. It also adds
support for `super` bounds, because they were discussed recently and
may be quite useful (and it turns out to be no problem to parse them).
Finally, a new test file is added to tests the additional constructs.

BUG=
R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/377b806bbccbc969bb11b25c17c913e6df3dc31f
==========

[eernst, 2016-04-14 13:25:56]

Committed patchset #4 (id:60001) manually as
377b806bbccbc969bb11b25c17c913e6df3dc31f (presubmit successful).