Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1878233002: PPC: [compiler] Add relocatable pointer constants for wasm memory references. (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [compiler] Add relocatable pointer constants for wasm memory references. Port eb5fe0df64ec0add423b2a1f6fb62d5a33dce2a5 Original commit message: Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. R=gdeepti@google.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/ded75f69536e94d4a19404454a6f0a6bbad15423 Cr-Commit-Position: refs/heads/master@{#35424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +18 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
MTBrandyberry
PTAL
4 years, 8 months ago (2016-04-12 15:35:18 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878233002/1
4 years, 8 months ago (2016-04-12 15:35:35 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/21)
4 years, 8 months ago (2016-04-12 15:46:25 UTC) #7
john.yan
lgtm
4 years, 8 months ago (2016-04-12 17:37:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878233002/1
4 years, 8 months ago (2016-04-12 17:43:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 17:50:24 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 17:51:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ded75f69536e94d4a19404454a6f0a6bbad15423
Cr-Commit-Position: refs/heads/master@{#35424}

Powered by Google App Engine
This is Rietveld 408576698