Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 187823006: Ensure that the chrome_200_percent.pak file is copied over to the destination folder on Windows. (Closed)

Created:
6 years, 9 months ago by ananta
Modified:
6 years, 9 months ago
Reviewers:
cpu_(ooo_6.6-7.5), sky
CC:
chromium-reviews
Visibility:
Public.

Description

Ensure that the chrome_200_percent.pak file is copied over to the destination folder on Windows. This will enable the installer on Windows to install the 200 percent assets. BUG=349607 R=cpu@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255448

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/common.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
ananta
6 years, 9 months ago (2014-03-05 22:09:12 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 9 months ago (2014-03-06 00:51:13 UTC) #2
ananta
+sky for chrome OWNERS
6 years, 9 months ago (2014-03-06 21:26:13 UTC) #3
sky
https://codereview.chromium.org/187823006/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/187823006/diff/20001/build/common.gypi#newcode181 build/common.gypi:181: # Enable HiDPI on Mac OS and Chrome OS. ...
6 years, 9 months ago (2014-03-06 22:03:08 UTC) #4
ananta
https://codereview.chromium.org/187823006/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/187823006/diff/20001/build/common.gypi#newcode181 build/common.gypi:181: # Enable HiDPI on Mac OS and Chrome OS. ...
6 years, 9 months ago (2014-03-06 22:06:39 UTC) #5
sky
Ok, LGTM
6 years, 9 months ago (2014-03-06 22:08:08 UTC) #6
ananta
6 years, 9 months ago (2014-03-06 22:10:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r255448 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698