Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 187823005: Bring back -fstack-protector-all on iOS. (Closed)

Created:
6 years, 9 months ago by justincohen
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Bring back -fstack-protector-all on iOS. This flag used to cause a crash on startup. As of Xcode 5 this doesn't appear to happen anymore. BUG=341484 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M build/common.gypi View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
justincohen
We brought this back on iOS builds and haven't seen any issues. PTAL!
6 years, 9 months ago (2014-03-05 20:32:49 UTC) #1
Mark Mentovai
Great! LGTM.
6 years, 9 months ago (2014-03-05 20:40:36 UTC) #2
justincohen
The CQ bit was checked by justincohen@chromium.org
6 years, 9 months ago (2014-03-05 20:59:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/187823005/1
6 years, 9 months ago (2014-03-05 20:59:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/187823005/1
6 years, 9 months ago (2014-03-06 00:00:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/187823005/1
6 years, 9 months ago (2014-03-06 02:41:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/187823005/1
6 years, 9 months ago (2014-03-06 03:11:12 UTC) #7
commit-bot: I haz the power
Change committed as 255263
6 years, 9 months ago (2014-03-06 05:41:41 UTC) #8
Ami GONE FROM CHROMIUM
6 years, 9 months ago (2014-03-20 21:47:10 UTC) #9
Message was sent while issue was closed.
Post-commit heads-up: this broke the WebRTC-on-iOS standalone build (chrome/ios
doesn't support webrtc).  Please follow along in
https://code.google.com/p/webrtc/issues/detail?id=3067 if interested.

Powered by Google App Engine
This is Rietveld 408576698