Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: Source/devtools/front_end/DataGrid.js

Issue 187823003: DevTools: Implement recursive viewport for the Heap Summary view (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove now unused DataGridNode.nodeHeight Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/DataGrid.js
diff --git a/Source/devtools/front_end/DataGrid.js b/Source/devtools/front_end/DataGrid.js
index c9b991c238981f84557f21e64ebb590a5c2ee1ee..cd7df8554fa2f55232512e8e096e8f492a34c3ef 100644
--- a/Source/devtools/front_end/DataGrid.js
+++ b/Source/devtools/front_end/DataGrid.js
@@ -1168,8 +1168,6 @@ WebInspector.DataGridNode = function(data, hasChildren)
this.disclosureToggleWidth = 10;
}
-WebInspector.DataGridNode.NodeShallowHeight = 16;
-
WebInspector.DataGridNode.prototype = {
/** @type {boolean} */
selectable: true,
@@ -1394,17 +1392,9 @@ WebInspector.DataGridNode.prototype = {
/**
* @return {number}
*/
- nodeHeight: function()
+ nodeSelfHeight: function()
{
- var rowHeight = WebInspector.DataGridNode.NodeShallowHeight;
- if (!this.revealed)
- return 0;
- if (!this.expanded)
- return rowHeight;
- var result = rowHeight;
- for (var i = 0; i < this.children.length; i++)
- result += this.children[i].nodeHeight();
- return result;
+ return 16;
},
/**
« no previous file with comments | « LayoutTests/inspector/profiler/heap-snapshot-test.js ('k') | Source/devtools/front_end/HeapSnapshotDataGrids.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698