DevTools: Implement recursive viewport for the Heap Summary view

DevTools: Implement recursive viewport for the Heap Summary view

BUG=255363
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168584

[alph, 2014-03-05 15:05:27]

ptal

[aandrey, 2014-03-05 15:24:28]

FYI

https://codereview.chromium.org/187823003/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/HeapSnapshotDataGrids.js (right):

https://codereview.chromium.org/187823003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/HeapSnapshotDataGrids.js:393:
child._shouldRefreshChildren = true;
I think this will result in going to backend for the data.
If so, doing it on every scroll event seems like an overkill, no?

[alph, 2014-03-05 15:40:54]

https://codereview.chromium.org/187823003/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/HeapSnapshotDataGrids.js (right):

https://codereview.chromium.org/187823003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/HeapSnapshotDataGrids.js:393:
child._shouldRefreshChildren = true;
On 2014/03/05 15:24:28, aandrey wrote:
> I think this will result in going to backend for the data.
> If so, doing it on every scroll event seems like an overkill, no?

Removed. It was a leftover, I do not actually need it.
Though DataGridNode.insertChild sets it to true anyway. However it wouldn't
actually do the real populate since _populated is true (see
HeapSnapshotGridNode.populate)

[yurys, 2014-03-05 15:52:53]

https://codereview.chromium.org/187823003/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/HeapSnapshotDataGrids.js (right):

https://codereview.chromium.org/187823003/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/HeapSnapshotDataGrids.js:417: var result =
WebInspector.DataGridNode.NodeShallowHeight;
Show More button is a bit higher than regular nodes so it seems that you should
ask the node about its height.

[alph, 2014-03-05 16:10:58]

https://codereview.chromium.org/187823003/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/HeapSnapshotDataGrids.js (right):

https://codereview.chromium.org/187823003/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/HeapSnapshotDataGrids.js:417: var result =
WebInspector.DataGridNode.NodeShallowHeight;
On 2014/03/05 15:52:54, yurys wrote:
> Show More button is a bit higher than regular nodes so it seems that you
should
> ask the node about its height.

Good catch! Fixed.

[yurys, 2014-03-05 16:21:39]

lgtm

[alph, 2014-03-05 16:21:50]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2014-03-05 16:22:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alph@chromium.org/187823003/80001

[commit-bot: I haz the power, 2014-03-05 20:59:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alph@chromium.org/187823003/80001

[commit-bot: I haz the power, 2014-03-06 02:21:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 02:21:55]

Try jobs failed on following builders: win_blink_rel

[alph, 2014-03-06 05:02:30]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2014-03-06 05:02:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alph@chromium.org/187823003/80001

[commit-bot: I haz the power, 2014-03-06 07:52:08]

Change committed as 168584