Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1878183002: [heap] Use safer predicate for API functions. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Use safer predicate for API functions. This uses the common predicate SharedFunctionInfo::IsApiFunction to determine flushability. Just a minor cleanup, no change in semantics. R=hpayer@chromium.org Committed: https://crrev.com/a58045a9893c96998282fbf441b178d0c44baa69 Cr-Commit-Position: refs/heads/master@{#35419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/heap/objects-visiting-inl.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-12 08:33:51 UTC) #1
Hannes Payer (out of office)
lgtm
4 years, 8 months ago (2016-04-12 14:27:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878183002/1
4 years, 8 months ago (2016-04-12 14:36:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 14:48:25 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 14:49:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a58045a9893c96998282fbf441b178d0c44baa69
Cr-Commit-Position: refs/heads/master@{#35419}

Powered by Google App Engine
This is Rietveld 408576698