Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 1878143004: Make SkSpecialSurfaces always use kUnknown for their pixel geometry (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkSpecialSurfaces always use kUnknown for their pixel geometry This now matches how the SkDevices were being created by the device proxy and prevents LCD text from being inadvertently applied. BUG=602555 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1878143004 Committed: https://skia.googlesource.com/skia/+/0b7e5a13bd371126b5d5794f3f9d2930c35ce05f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/core/SkSpecialSurface.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 8 months ago (2016-04-13 12:36:45 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878143004/1
4 years, 8 months ago (2016-04-13 12:37:11 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 12:50:21 UTC) #8
Stephen White
LGTM
4 years, 8 months ago (2016-04-13 13:45:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878143004/1
4 years, 8 months ago (2016-04-13 14:17:46 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 14:18:45 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0b7e5a13bd371126b5d5794f3f9d2930c35ce05f

Powered by Google App Engine
This is Rietveld 408576698