Enable App List Sync by default

Enable App List Sync by default

BUG=305024
For chrome/browser/sync

R=jennyz@chromium.org, tapted@chromium.org
TBR=zea@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255982

[tapted, 2014-03-05 22:33:38]

lgtm with the changes below

https://codereview.chromium.org/187813006/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/187813006/diff/1/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:1313: "enable-sync-app-list",
Pretty sure this needs to change too. The comment about it ("you shouldn't
change the name of existing flags") is a bit misleading -- I think the result
would be that any early-adopters would become auto-disabled when this blips out.

https://codereview.chromium.org/187813006/diff/1/chrome/browser/sync/profile_...
File chrome/browser/sync/profile_sync_components_factory_impl.cc (right):

https://codereview.chromium.org/187813006/diff/1/chrome/browser/sync/profile_...
chrome/browser/sync/profile_sync_components_factory_impl.cc:347: // App List
sync is disabled by default.  Register only if enabled.
nit: update comment

[jennyz, 2014-03-05 22:39:19]

lgtm, the flag name should be changed.

https://codereview.chromium.org/187813006/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/187813006/diff/1/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:1313: "enable-sync-app-list",
On 2014/03/05 22:33:38, tapted wrote:
> Pretty sure this needs to change too. The comment about it ("you shouldn't
> change the name of existing flags") is a bit misleading -- I think the result
> would be that any early-adopters would become auto-disabled when this blips
out.

+1

[stevenjb, 2014-03-05 23:19:59]

https://codereview.chromium.org/187813006/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/187813006/diff/1/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:1313: "enable-sync-app-list",
On 2014/03/05 22:33:38, tapted wrote:
> Pretty sure this needs to change too. The comment about it ("you shouldn't
> change the name of existing flags") is a bit misleading -- I think the result
> would be that any early-adopters would become auto-disabled when this blips
out.

DOh. Thanks, you're right.
Done.

https://codereview.chromium.org/187813006/diff/1/chrome/browser/sync/profile_...
File chrome/browser/sync/profile_sync_components_factory_impl.cc (right):

https://codereview.chromium.org/187813006/diff/1/chrome/browser/sync/profile_...
chrome/browser/sync/profile_sync_components_factory_impl.cc:347: // App List
sync is disabled by default.  Register only if enabled.
On 2014/03/05 22:33:38, tapted wrote:
> nit: update comment

Done.

[stevenjb, 2014-03-05 23:20:03]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-03-05 23:24:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/187813006/20001

[commit-bot: I haz the power, 2014-03-06 00:10:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/187813006/20001

[commit-bot: I haz the power, 2014-03-06 01:13:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 01:13:59]

Try jobs failed on following builders: linux_chromium_rel

[stevenjb, 2014-03-06 20:15:25]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-03-06 20:46:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/187813006/40001

[commit-bot: I haz the power, 2014-03-06 21:37:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/187813006/40001

[commit-bot: I haz the power, 2014-03-06 22:12:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/187813006/40001

[commit-bot: I haz the power, 2014-03-06 23:12:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 23:12:03]

Try jobs failed on following builders: linux_chromium_rel

[stevenjb, 2014-03-10 18:19:54]

Committed patchset #4 manually as r255982 (presubmit successful).