Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Unified Diff: Source/core/rendering/RenderObject.cpp

Issue 187813004: Use outlineBox if we have an outline or shadow (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderObject.cpp
diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp
index 2b6ae7a1b380aa24cd0a05fc8ac3a1fc2914f332..29ce2ee7614ddfe821a337cf5d74c3bba14601e7 100644
--- a/Source/core/rendering/RenderObject.cpp
+++ b/Source/core/rendering/RenderObject.cpp
@@ -1514,7 +1514,10 @@ bool RenderObject::repaintAfterLayoutIfNeeded(const RenderLayerModelObject* repa
// This ASSERT fails due to animations. See https://bugs.webkit.org/show_bug.cgi?id=37048
// ASSERT(!newOutlineBoxRectPtr || *newOutlineBoxRectPtr == outlineBoundsForRepaint(repaintContainer));
newOutlineBox = newOutlineBoxRectPtr ? *newOutlineBoxRectPtr : outlineBoundsForRepaint(repaintContainer);
- if (newOutlineBox.location() != oldOutlineBox.location() || (mustRepaintBackgroundOrBorder() && (newBounds != oldBounds || newOutlineBox != oldOutlineBox)))
+
+ bool hasOutlineBox = hasOutline() || (style()->boxShadow() && style()->boxShadow()->shadows().size() > 0);
Julien - ping for review 2014/03/07 00:01:10 style()->boxShadow() && style()->boxShadow()->shad
dsinclair 2014/03/07 03:18:56 Done.
+ if ((hasOutlineBox && newOutlineBox.location() != oldOutlineBox.location())
+ || (mustRepaintBackgroundOrBorder() && (newBounds != oldBounds || (hasOutlineBox && newOutlineBox != oldOutlineBox))))
fullRepaint = true;
}
« Source/core/rendering/RenderBlock.cpp ('K') | « Source/core/rendering/RenderBlockFlow.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698