Source/core/rendering/RenderBlock.h - Issue 187813004: Use outlineBox if we have an outline or shadow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.h

Issue 187813004: Use outlineBox if we have an outline or shadow (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderBlock.h

diff --git a/Source/core/rendering/RenderBlock.h b/Source/core/rendering/RenderBlock.h

index 5907dc28abbb75be260c603ac3c1b7f00e75dad1..21ac2f0c8a6abec1d9be9fabc118f8fa9427d460 100644

--- a/Source/core/rendering/RenderBlock.h

+++ b/Source/core/rendering/RenderBlock.h

@@ -290,7 +290,7 @@ protected:

virtual void layout() OVERRIDE;

virtual bool updateImageLoadingPriorities() OVERRIDE FINAL;

- void layoutPositionedObjects(bool relayoutChildren, bool fixedPositionObjectsOnly = false);

+ void layoutPositionedObjects(bool relayoutChildren, bool fixedPositionObjectsOnly = false, bool parentMoved = false);

Julien - ping for review 2014/03/07 00:01:10 Really not a huge fan of more booleans here.

dsinclair 2014/03/07 03:18:56 Better?

void markFixedPositionObjectForLayoutIfNeeded(RenderObject* child, SubtreeLayoutScope&);

LayoutUnit marginIntrinsicLogicalWidthForChild(RenderBox* child) const;