Use outlineBox if we have an outline or shadow

Source/core/rendering/RenderBlock.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 1713 matching lines @@
     Length marginLeft = child->style()->marginStartUsing(style());
     Length marginRight = child->style()->marginEndUsing(style());
     LayoutUnit margin = 0;
     if (marginLeft.isFixed())
         margin += marginLeft.value();
     if (marginRight.isFixed())
         margin += marginRight.value();
     return margin;
 }
 
-void RenderBlock::layoutPositionedObjects(bool relayoutChildren, bool fixedPositionObjectsOnly)
+void RenderBlock::layoutPositionedObjects(bool relayoutChildren, bool fixedPositionObjectsOnly, bool parentMoved)

[Julien - ping for review, 2014/03/07 00:01:10]

s/parent/containingBlock/ (positioned object is the reason why we talk about
containing blocks and not parents :))

[dsinclair, 2014/03/07 03:18:56]

Done.

 {
     TrackedRendererListHashSet* positionedDescendants = positionedObjects();
     if (!positionedDescendants)
         return;
 
     if (hasColumns())
         view()->layoutState()->clearPaginationInformation(); // Positioned objects are not part of the column flow, so they don't paginate with the columns.
 
     RenderBox* r;
     TrackedRendererListHashSet::iterator end = positionedDescendants->end();
@@ skipping 34 matching lines @@
         LayoutUnit oldLogicalTop = 0;
         bool needsBlockDirectionLocationSetBeforeLayout = r->needsLayout() && view()->layoutState()->needsBlockDirectionLocationSetBeforeLayout();
         if (needsBlockDirectionLocationSetBeforeLayout) {
             if (isHorizontalWritingMode() == r->isHorizontalWritingMode())
                 r->updateLogicalHeight();
             else
                 r->updateLogicalWidth();
             oldLogicalTop = logicalTopForChild(r);
         }
 
+        if (parentMoved)
+            r->setNeedsLayout();

[Julien - ping for review, 2014/03/07 00:01:10]

Is this guaranteed to work? We only ensure that the positioned objects that are
under |this| get repainted, not the whole positioned hierarchy, which is what we
would need (logicalLeft is the offset from your containing block which has only
changed for the renderer being shifted)

Also shouldn't this be setNeedsPositionedMovementLayout() for the case you're
interested in?

[dsinclair, 2014/03/07 03:18:56]

I don't know? This seemed to work for the test case I have, not sure if there
are other cases that need to be handled in here as well.
If I do r->setNeedsPositionedMovementLayout() here it doesn't seem to cause the
invalidation. Having it as setNeedsLayout() does trigger the invalidation. Is
there something else I'm missing?.

[Julien - ping for review, 2014/03/08 01:26:53]

The whole positioned hierarchy is shifted in this case but we only ever force an
invalidation for the direct positioned descendant. We talked about some cases I
thought would defeat this but they worked which makes me wonder if something
else is not generating invalidations.
That's weird, maybe a full layout forces the descendants to be invalidated. I
would rather have this understood and investigated as this will definitely bite
us down the road. I could live with a FIXME with a blocking bug on RAL but only
if this blocks something.

[dsinclair, 2014/03/10 00:22:51]

Done.

crbug.com/350756  I didn't mark the bug as blocking RAL as I don't think it
blocks anything at the moment?

+
         r->layoutIfNeeded();
 
         // Lay out again if our estimate was wrong.
         if (needsBlockDirectionLocationSetBeforeLayout && logicalTopForChild(r) != oldLogicalTop)
             r->forceChildLayout();
     }
 
     if (hasColumns())
         view()->layoutState()->m_columnInfo = columnInfo(); // FIXME: Kind of gross. We just put this back into the layout state so that pop() will work.
 }
@@ skipping 3219 matching lines @@
 void RenderBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* markedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const RenderObject* obj) const
 {
     showRenderObject();
     for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRootBox())
         root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLabel2, obj, 1);
 }
 
 #endif
 
 } // namespace WebCore