Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1878123003: DevTools: fix elements-panel-shadow-selection-on-refresh.html (Closed)

Created:
4 years, 8 months ago by lushnikov
Modified:
4 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix elements-panel-shadow-selection-on-refresh.html BUG=577870 R=dgozman Committed: https://crrev.com/12f2b7ec4bc05357bdb313e1d1e7898e45724bc6 Cr-Commit-Position: refs/heads/master@{#386850}

Patch Set 1 #

Patch Set 2 : split test into many #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -156 lines) Patch
M third_party/WebKit/LayoutTests/SlowTests View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/shadow/elements-panel-shadow-selection-on-refresh.html View 1 1 chunk +0 lines, -122 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/shadow/elements-panel-shadow-selection-on-refresh.js View 1 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/shadow/elements-panel-shadow-selection-on-refresh-1.html View 1 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/shadow/elements-panel-shadow-selection-on-refresh-1-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/shadow/elements-panel-shadow-selection-on-refresh-2.html View 1 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/shadow/elements-panel-shadow-selection-on-refresh-2-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/shadow/elements-panel-shadow-selection-on-refresh-3.html View 1 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/shadow/elements-panel-shadow-selection-on-refresh-3-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/elements/shadow/elements-panel-shadow-selection-on-refresh-expected.txt View 1 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
lushnikov
ptal
4 years, 8 months ago (2016-04-12 03:05:56 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878123003/1
4 years, 8 months ago (2016-04-12 03:06:40 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/210766)
4 years, 8 months ago (2016-04-12 05:21:00 UTC) #5
dgozman
Seems like this didn't work?
4 years, 8 months ago (2016-04-12 17:15:13 UTC) #6
lushnikov
split into many tests - should work now
4 years, 8 months ago (2016-04-12 21:39:41 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878123003/20001
4 years, 8 months ago (2016-04-12 21:42:15 UTC) #9
dgozman
lgtm
4 years, 8 months ago (2016-04-12 22:23:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878123003/20001
4 years, 8 months ago (2016-04-12 23:08:52 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 23:17:15 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 23:19:42 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/12f2b7ec4bc05357bdb313e1d1e7898e45724bc6
Cr-Commit-Position: refs/heads/master@{#386850}

Powered by Google App Engine
This is Rietveld 408576698