Issue 18781002: Revert "Improve forwarder2 setup/tear down in telemetry."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18781002: Revert "Improve forwarder2 setup/tear down in telemetry." (Closed)

Created:
7 years, 5 months ago by Philippe

Modified:
7 years, 5 months ago

Reviewers:
bulach, Michael van Ouwerkerk

CC:
chromium-reviews, craigdh+watch_chromium.org, chrome-speed-team+watch_google.com, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, telemetry+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Improve forwarder2 setup/tear down in telemetry." This reverts r210268 which made some tests fail downstream. TBR=bulach@chromium.org,mvanouwerkerk@chromium.org BUG=210268 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210311

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -47 lines)			Patch
M	build/android/bb_run_sharded_steps.py	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	build/android/pylib/forwarder.py	View	4 chunks	+14 lines, -27 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/adb_commands.py	View	1 chunk	+5 lines, -14 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/android_browser_backend.py	View	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Philippe

Committed patchset #1 manually as r210311 (presubmit successful).

7 years, 5 months ago (2013-07-05 15:45:58 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages