Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: url/url_canon_internal_file.h

Issue 1878083002: Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git sync Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: url/url_canon_internal_file.h
diff --git a/url/url_canon_internal_file.h b/url/url_canon_internal_file.h
index 26a3eae514f937c1b930a529f8827bad84d5474c..61b99cc036499692a584a2f73bc23bea0522bbf0 100644
--- a/url/url_canon_internal_file.h
+++ b/url/url_canon_internal_file.h
@@ -14,7 +14,7 @@
// *** This file must be included after url_canon_internal as we depend on some
// functions in it. ***
-
+#include "base/strings/string_util.h"
#include "url/url_file.h"
#include "url/url_parse_internal.h"
@@ -40,7 +40,7 @@ static int FileDoDriveSpec(const CHAR* spec, int begin, int end,
// and that it is followed by a colon/pipe.
// Normalize Windows drive letters to uppercase
- if (spec[after_slashes] >= 'a' && spec[after_slashes] <= 'z')
+ if (base::IsAsciiLower(spec[after_slashes]))
output->push_back(spec[after_slashes] - 'a' + 'A');
else
output->push_back(static_cast<char>(spec[after_slashes]));

Powered by Google App Engine
This is Rietveld 408576698