Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h

url/url_canon_internal_file.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef URL_URL_CANON_INTERNAL_FILE_H_
 #define URL_URL_CANON_INTERNAL_FILE_H_
 
 // As with url_canon_internal.h, this file is intended to be included in
 // another C++ file where the template types are defined. This allows the
 // programmer to use this to use these functions for their own strings
 // types, without bloating the code by having inline templates used in
 // every call site.
 //
 // *** This file must be included after url_canon_internal as we depend on some
 // functions in it. ***
 
-
+#include "base/strings/string_util.h"
 #include "url/url_file.h"
 #include "url/url_parse_internal.h"
 
 namespace url {
 
 // Given a pointer into the spec, this copies and canonicalizes the drive
 // letter and colon to the output, if one is found. If there is not a drive
 // spec, it won't do anything. The index of the next character in the input
 // spec is returned (after the colon when a drive spec is found, the begin
 // offset if one is not).
 template<typename CHAR>
 static int FileDoDriveSpec(const CHAR* spec, int begin, int end,
                            CanonOutput* output) {
   // The path could be one of several things: /foo/bar, c:/foo/bar, /c:/foo,
   // (with backslashes instead of slashes as well).
   int num_slashes = CountConsecutiveSlashes(spec, begin, end);
   int after_slashes = begin + num_slashes;
 
   if (!DoesBeginWindowsDriveSpec(spec, after_slashes, end))
     return begin;  // Haven't consumed any characters
 
   // DoesBeginWindowsDriveSpec will ensure that the drive letter is valid
   // and that it is followed by a colon/pipe.
 
   // Normalize Windows drive letters to uppercase
-  if (spec[after_slashes] >= 'a' && spec[after_slashes] <= 'z')
+  if (base::IsAsciiLower(spec[after_slashes]))
     output->push_back(spec[after_slashes] - 'a' + 'A');
   else
     output->push_back(static_cast<char>(spec[after_slashes]));
 
   // Normalize the character following it to a colon rather than pipe.
   output->push_back(':');
   output->push_back('/');
   return after_slashes + 2;
 }
 
@@ skipping 72 matching lines @@
       source.query, parsed.query, output, &new_parsed->query);
   success &= URLCanonInternal<CHAR, UCHAR>::DoRef(
       source.ref, parsed.ref, output, &new_parsed->ref);
 
   return success;
 }
 
 }  // namespace url
 
 #endif  // URL_URL_CANON_INTERNAL_FILE_H_