Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h

components/test_runner/event_sender.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/test_runner/event_sender.h"
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 379 matching lines @@
     }
   }
 
   return strings;
 }
 
 // How much we should scroll per event - the value here is chosen to match the
 // WebKit impl and layout test results.
 const float kScrollbarPixelsPerTick = 40.0f;
 
-bool NeedsShiftModifier(int keyCode) {
-  // If code is an uppercase letter, assign a SHIFT key to eventDown.modifier.
-  return (keyCode & 0xFF) >= 'A' && (keyCode & 0xFF) <= 'Z';
-}
-
 // Get the edit command corresponding to a keyboard event.
 // Returns true if the specified event corresponds to an edit command, the name
 // of the edit command will be stored in |*name|.
 bool GetEditCommand(const WebKeyboardEvent& event, std::string* name) {
 #if defined(OS_MACOSX)
 // We only cares about Left,Right,Up,Down keys with Command or Command+Shift
 // modifiers. These key events correspond to some special movement and
 // selection editor commands. These keys will be marked as system key, which
 // prevents them from being handled. Thus they must be handled specially.
   if ((event.modifiers & ~WebKeyboardEvent::ShiftKey) !=
@@ skipping 1107 matching lines @@
     }
     if (!code) {
       base::string16 code_str16 = base::UTF8ToUTF16(code_str);
       if (code_str16.size() != 1u) {
         v8::Isolate* isolate = blink::mainThreadIsolate();
         isolate->ThrowException(v8::Exception::TypeError(
             gin::StringToV8(isolate, "Invalid web code.")));
         return;
       }
       text = code = code_str16[0];
-      needs_shift_key_modifier = NeedsShiftModifier(code);
-      if ((code & 0xFF) >= 'a' && (code & 0xFF) <= 'z')
+      needs_shift_key_modifier = base::IsAsciiUpper(code & 0xFF);
+      if (base::IsAsciiLower(code & 0xFF))
         code -= 'a' - 'A';
-      if ((code >= 'A' && code <= 'Z') || (code >= 'a' && code <= 'z')) {
+      if (base::IsAsciiAlpha(code)) {
         domString.assign("Key");
         domString.push_back(
             base::ToUpperASCII(static_cast<base::char16>(code)));
-      } else if (code >= '0' && code <= '9') {
+      } else if (base::IsAsciiDigit(code)) {
         domString.assign("Digit");
         domString.push_back(code);
       } else if (code == ' ') {
         domString.assign("Space");
       } else if (code == 9) {
         domString.assign("Tab");
       }
       generate_char = true;
     }
 
@@ skipping 1213 matching lines @@
                                  &end_event);
   end_event.data.scrollEnd.deltaUnits =
       begin_event.data.scrollBegin.deltaHintUnits;
 
   if (force_layout_on_events_)
     view_->updateAllLifecyclePhases();
   HandleInputEventOnViewOrPopup(end_event);
 }
 
 }  // namespace test_runner