Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1878063004: Revert of Visit the Optimized Code Map on first call rather than closure creation. (Closed)

Created:
4 years, 8 months ago by Michael Hablich
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Visit the Optimized Code Map on first call rather than closure creation. (patchset #7 id:120001 of https://codereview.chromium.org/1670143002/ ) Reason for revert: Blocks roll. See https://codereview.chromium.org/1877003002/ for detailed messages. You should be able to repro this with Linux ASAN. Original issue's description: > Visit the Optimized Code Map on first call rather than closure creation. > > This is useful for escape analysis, and helps upcoming changes to > type feedback gathering. > > BUG= > > Committed: https://crrev.com/9336f4cc6d25d39a128176679a70dbd13a6d946e > Cr-Commit-Position: refs/heads/master@{#35395} TBR=mstarzinger@chromium.org,bmeurer@chromium.org,mvstanton@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/f021b7ca8f41c22317df57896480f52b9a9f1bdc Cr-Commit-Position: refs/heads/master@{#35404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -904 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +0 lines, -153 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +0 lines, -132 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 3 chunks +200 lines, -7 lines 0 comments Download
M src/compiler.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +0 lines, -148 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +0 lines, -148 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 2 chunks +1 line, -148 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +0 lines, -128 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 6 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Hablich
Created Revert of Visit the Optimized Code Map on first call rather than closure creation.
4 years, 8 months ago (2016-04-12 07:58:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878063004/1
4 years, 8 months ago (2016-04-12 07:58:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 07:58:38 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 07:59:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f021b7ca8f41c22317df57896480f52b9a9f1bdc
Cr-Commit-Position: refs/heads/master@{#35404}

Powered by Google App Engine
This is Rietveld 408576698