Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 1878063002: Revert "Record UMA for Physical Web state" (Closed)

Created:
4 years, 8 months ago by cco3
Modified:
4 years, 8 months ago
Reviewers:
rschoen, nyquist, RyanS, Yaron, Maria
CC:
chromium-reviews, asvitkine+watch_chromium.org, mattreynolds
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Record UMA for Physical Web state" This reverts commit 10cbc3ad60388fc48ebfbbd16c8d3db9872c009b. BUG=602306 Committed: https://crrev.com/eff4f562bcf2a0655fab689a1eb5fbde97f2f7ba Cr-Commit-Position: refs/heads/master@{#386855}

Patch Set 1 #

Patch Set 2 : Leave histogram change #

Messages

Total messages: 27 (13 generated)
cco3
4 years, 8 months ago (2016-04-11 22:59:52 UTC) #2
cco3
Apparently this is causing a memory issue. Reverting until we can figure it out.
4 years, 8 months ago (2016-04-11 23:17:39 UTC) #4
rschoen
Perf sheriff LGTM, but I know nothing of the code :)
4 years, 8 months ago (2016-04-11 23:22:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878063002/1
4 years, 8 months ago (2016-04-11 23:36:04 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-11 23:36:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878063002/20001
4 years, 8 months ago (2016-04-11 23:45:11 UTC) #12
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-11 23:45:13 UTC) #14
rschoen
Right, I'm also not a committer.
4 years, 8 months ago (2016-04-11 23:52:05 UTC) #15
cco3
Hi, could any of the committers here give me approval on this revert?
4 years, 8 months ago (2016-04-12 21:21:02 UTC) #19
Yaron
On 2016/04/12 21:21:02, cco3 wrote: > Hi, could any of the committers here give me ...
4 years, 8 months ago (2016-04-12 21:23:38 UTC) #20
cco3
On 2016/04/12 21:23:38, Yaron wrote: > On 2016/04/12 21:21:02, cco3 wrote: > > Hi, could ...
4 years, 8 months ago (2016-04-12 21:25:49 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878063002/20001
4 years, 8 months ago (2016-04-12 21:26:26 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 23:21:06 UTC) #25
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 23:23:24 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eff4f562bcf2a0655fab689a1eb5fbde97f2f7ba
Cr-Commit-Position: refs/heads/master@{#386855}

Powered by Google App Engine
This is Rietveld 408576698