Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 1878033002: [Mac/GN] Add new template for creating .plugin loadable modules. (Closed)

Created:
4 years, 8 months ago by Robert Sesek
Modified:
4 years, 8 months ago
Reviewers:
brettw, raymes, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Add new template for creating .plugin loadable modules. Plugins are just loadable_module targets with a bundle directory structure. This also builds two plugins in //ppapi that are required to build //content/shell. BUG=297668 Committed: https://crrev.com/53dc3107bd03d046cc9d72dae1a41233660c1712 Cr-Commit-Position: refs/heads/master@{#387970}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -2 lines) Patch
M build/config/mac/rules.gni View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
M ppapi/BUILD.gn View 4 chunks +34 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Robert Sesek
4 years, 8 months ago (2016-04-11 23:04:02 UTC) #2
sdefresne
lgtm
4 years, 8 months ago (2016-04-12 16:07:34 UTC) #3
Robert Sesek
+raymes for //ppapi OWNERS
4 years, 8 months ago (2016-04-12 16:15:12 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878033002/20001
4 years, 8 months ago (2016-04-12 22:43:14 UTC) #7
raymes
+brettw - Brett, should we try to have a template that handles building plugins on ...
4 years, 8 months ago (2016-04-12 22:52:47 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-12 23:35:42 UTC) #11
Robert Sesek
On 2016/04/12 22:52:47, raymes wrote: > +brettw - Brett, should we try to have a ...
4 years, 8 months ago (2016-04-13 18:27:22 UTC) #12
Robert Sesek
brettw: ping
4 years, 8 months ago (2016-04-14 20:07:04 UTC) #13
brettw
lgtm
4 years, 8 months ago (2016-04-18 17:11:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878033002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878033002/40001
4 years, 8 months ago (2016-04-18 17:59:13 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-18 18:48:51 UTC) #18
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 18:53:24 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/53dc3107bd03d046cc9d72dae1a41233660c1712
Cr-Commit-Position: refs/heads/master@{#387970}

Powered by Google App Engine
This is Rietveld 408576698