chrome/test/data/extensions/api_test/notifications/galore/app/controller.js - Issue 187803005: Remove uses of the Legacy Notification API and tests on Linux Aura

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/notifications/galore/app/controller.js

Issue 187803005: Remove uses of the Legacy Notification API and tests on Linux Aura (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/activity_log_private/test/test.js ('k') | chrome/test/data/extensions/api_test/notifications/has_not_permission/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/notifications/galore/app/controller.js

diff --git a/chrome/test/data/extensions/api_test/notifications/galore/app/controller.js b/chrome/test/data/extensions/api_test/notifications/galore/app/controller.js

index 2c4ede057e917677e9f0424031fa53778080a4fe..5f5aa1ad6f3f19f6a4124318cc0dc4f00440576e 100644

--- a/chrome/test/data/extensions/api_test/notifications/galore/app/controller.js

+++ b/chrome/test/data/extensions/api_test/notifications/galore/app/controller.js

@@ -123,7 +123,10 @@ Galore.controller = {

var iconUrl = options.iconUrl;

var title = options.title;

var message = options.message;

- webkitNotifications.createNotification(iconUrl, title, message).show();

+ new Notification(title, {

+ body: message,

+ icon: iconUrl

+ });

this.handleEvent_('create', '?', 'title: "' + title + '"');