Make CFX_{Byte,Wide}String::Remove() no-touch if possible

Make CFX_{Byte,Wide}String::Remove() no-touch if possible

Don't try to copy the string until we are sure we need to
change it.

Committed: https://pdfium.googlesource.com/pdfium/+/e09c1e4db92e28a332f55aa3c80ceb44f4b74287

[Tom Sepez, 2016-04-11 21:36:42]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-11 21:36:43]

Lei, for review. Thanks.

[Lei Zhang, 2016-04-11 21:47:57]

lgtm

https://codereview.chromium.org/1877993002/diff/1/core/fxcrt/fx_basic_wstring...
File core/fxcrt/fx_basic_wstring.cpp (right):

https://codereview.chromium.org/1877993002/diff/1/core/fxcrt/fx_basic_wstring...
core/fxcrt/fx_basic_wstring.cpp:682: 
BTW, there's an extra blank line vs bstring version. Not sure if you care to
keep them in sync.

[Tom Sepez, 2016-04-12 00:36:46]

https://codereview.chromium.org/1877993002/diff/1/core/fxcrt/fx_basic_wstring...
File core/fxcrt/fx_basic_wstring.cpp (right):

https://codereview.chromium.org/1877993002/diff/1/core/fxcrt/fx_basic_wstring...
core/fxcrt/fx_basic_wstring.cpp:682: 
On 2016/04/11 21:47:57, Lei Zhang wrote:
> BTW, there's an extra blank line vs bstring version. Not sure if you care to
> keep them in sync.

Done.

[Tom Sepez, 2016-04-12 00:36:49]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-04-12 00:36:49]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1877993002/#ps20001
(title: "Extra blank line.")

[commit-bot: I haz the power, 2016-04-12 00:36:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877993002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877993002/20001

[commit-bot: I haz the power, 2016-04-12 01:01:16]

Description was changed from

==========
Make CFX_{Byte,Wide}String::Remove() no-touch if possible

Don't try to copy the string until we are sure we need to
change it.
==========

to

==========
Make CFX_{Byte,Wide}String::Remove() no-touch if possible

Don't try to copy the string until we are sure we need to
change it.

Committed:
https://pdfium.googlesource.com/pdfium/+/e09c1e4db92e28a332f55aa3c80ceb44f4b7...
==========

[commit-bot: I haz the power, 2016-04-12 01:01:16]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/e09c1e4db92e28a332f55aa3c80ceb44f4b7...