runtime/vm/object.cc - Issue 1877973002: Invalidate background compilation only if relevant fields were invalidated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 1877973002: Invalidate background compilation only if relevant fields were invalidated. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: sync Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index a02ce2761597c98a681f788f86efb920066026ab..e3390b33d01e5d92a187b372c29f2167a5e23274 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -7745,8 +7745,11 @@ void Field::RegisterDependentCode(const Code& code) const {

void Field::DeoptimizeDependentCode() const {

- ASSERT(IsOriginal());

ASSERT(Thread::Current()->IsMutatorThread());

+ ASSERT(IsOriginal());

+ if (FLAG_background_compilation) {

+ Isolate::Current()->AddDisablingField(*this);

+ }

FieldDependentArray a(*this);

a.DisableCode();

}

« runtime/vm/compiler.cc ('K') | « runtime/vm/isolate.cc ('k') | no next file » | no next file with comments »