mastermon: collect step results count

infra/services/mastermon/test/pollers_test.py

 # Copyright (c) 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import os
-import tempfile
 import time
 import unittest
 
 import mock
 import requests
 
 from infra_libs import temporary_directory
 from infra_libs import ts_mon
 from infra.services.mastermon import pollers
 
@@ skipping 186 matching lines @@
         f.write('%s\n' % json.dumps(data))
       return f.name
 
   def test_no_file(self):
     with temporary_directory(prefix='poller-test-') as tempdir:
       filename = os.path.join(tempdir, 'no-such-file')
       p = pollers.FilePoller(filename, {})
       self.assertTrue(p.poll())
       self.assertFalse(os.path.isfile(pollers.rotated_filename(filename)))
 
-  @mock.patch('infra_libs.ts_mon.CounterMetric.increment')
-  @mock.patch('infra_libs.ts_mon.CumulativeDistributionMetric.add')
-  def test_file_has_data(self, fake_add, fake_increment):
+  def test_file_has_data(self):
     result1 = {'builder': 'b1', 'slave': 's1',
                'result': 'r1', 'project_id': 'chromium',
                'subproject_tag': 'unknown'}
     result2 = {'builder': 'b1', 'slave': 's1',
                'result': 'r1', 'project_id': 'unknown',
                'subproject_tag': 'unknown'}
+    result3 = {'builder': 'b1', 'slave': 's1',
+               'step_result': 'r1', 'project_id': 'chromium',
+               'subproject_tag': 'unknown'}
     # Check that we've listed all the required metric fields.
-    self.assertEqual(set(result1), set(pollers.FilePoller.field_keys))
-    self.assertEqual(set(result2), set(pollers.FilePoller.field_keys))
+    self.assertEqual(set(result1), set(pollers.FilePoller.build_field_keys))
+    self.assertEqual(set(result2), set(pollers.FilePoller.build_field_keys))
+    self.assertEqual(set(result3), set(pollers.FilePoller.step_field_keys))
 
-    data1 = result1.copy()
-    data2 = result2.copy()
-    data1['random'] = 'value'  # Extra field, should be ignored.
-    del data2['project_id']    # Missing field, should become 'unknown'.
-    data2['duration_s'] = 5
-    data2['pending_s'] = 1
-    data2['total_s'] = data2['pending_s'] + data2['duration_s']
-    data2['pre_test_time_s'] = 2
+    data = [r.copy() for r in (result1, result2, result3)]
+    data[0]['random'] = 'value'  # Extra field, should be ignored.
+    del data[1]['project_id']    # Missing field, should become 'unknown'.
+    data[1]['duration_s'] = 5
+    data[1]['pending_s'] = 1
+    data[1]['total_s'] = data[1]['pending_s'] + data[1]['duration_s']
+    data[1]['pre_test_time_s'] = 2
     with temporary_directory(prefix='poller-test-') as tempdir:
-      filename = self.create_data_file(tempdir, [data1, data2])
+      filename = self.create_data_file(tempdir, data)
       p = pollers.FilePoller(filename, {})
       self.assertTrue(p.poll())
-      fake_increment.assert_any_call(result1)
-      fake_increment.assert_any_call(result2)
-      fake_add.assert_any_call(data2['duration_s'], result2)
-      fake_add.assert_any_call(data2['pending_s'], result2)
-      fake_add.assert_any_call(data2['total_s'], result2)
+
+      self.assertEqual(pollers.FilePoller.result_count.get(result1), 1)
+      self.assertEqual(pollers.FilePoller.result_count.get(result2), 1)
+      self.assertEqual(pollers.FilePoller.step_results_count.get(result3), 1)
+
       self.assertFalse(os.path.isfile(filename))
       # Make sure the rotated file is still there - for debugging.
       self.assertTrue(os.path.isfile(pollers.rotated_filename(filename)))
 
   def test_file_has_bad_data(self):
     """Mostly a smoke test: don't crash on bad data."""
     with temporary_directory(prefix='poller-test-') as tempdir:
       filename = self.create_data_file(tempdir, [])
       with open(filename, 'a') as f:
         f.write('}')
       p = pollers.FilePoller(filename, {})
       self.assertTrue(p.poll())
       self.assertFalse(os.path.isfile(filename))
       # Make sure the rotated file is still there - for debugging.
       self.assertTrue(os.path.isfile(pollers.rotated_filename(filename)))
 
   def test_safe_remove_error(self):
     """Smoke test: the function should not raise an exception."""
     pollers.safe_remove('nonexistent-file')