Fill out the rest of the StringPiece functions for 16-bit.

Fill out the rest of the StringPiece functions for 16-bit.

I was originally opposed to these since we didn't need them and they were complicated. But I'm wanting to use some of these functions in a different patch, so it seems like a good time to fill out the std::string-like finding functions for StringPiece16.

This deletes the old StringPieceDetails for which the only point was to share the common stuff between the two BasicStringPiece specializations.

I used the pattern of having two versions of each function declared in the header and then expanding the template in the .cc file, to avoid template bloat in the header.

This replaces all of the size_type goop with size_t. Chrome code assumes these are the same and we encourage people to just use size_t in loops, for example, rather than using the size_type of the template they're iterating over. This makes the code more readable in many places. It also solves a problem with declaration ordering since most of the functions that used size_type are now moved above where the size_type is actually declared.

R=viettrungluu@chromium.org
TBR=akalin, ben

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255397

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256311

[viettrungluu, 2014-03-05 22:52:23]

lgtm w/nits

https://codereview.chromium.org/187793004/diff/40001/base/strings/string_piec...
File base/strings/string_piece.cc (right):

https://codereview.chromium.org/187793004/diff/40001/base/strings/string_piec...
base/strings/string_piece.cc:372: --self_i) {
nit: this fits on the previous line

https://codereview.chromium.org/187793004/diff/40001/base/strings/string_piec...
base/strings/string_piece.cc:394: --i) {
"

https://codereview.chromium.org/187793004/diff/40001/base/strings/string_piece.h
File base/strings/string_piece.h (right):

https://codereview.chromium.org/187793004/diff/40001/base/strings/string_piec...
base/strings/string_piece.h:48: // So here we define overridden functions called
by the StringPiece template.
overridden -> overloaded?

https://codereview.chromium.org/187793004/diff/40001/base/strings/string_piec...
base/strings/string_piece.h:159: // Standard STL container boilerplate
Nit: Still needs punctuation.

[brettw, 2014-03-05 23:24:18]

TBR akalin for net
TBR ben for ui

[brettw, 2014-03-06 17:54:38]

Committed patchset #5 manually as r255397 (presubmit successful).

[brettw, 2014-03-10 20:07:06]

Trung: PTAL (diff vs. patch 5) for memory fix. I accidentally removed the check
when I adapted the code. I really don't like this pattern of using unsigned
indices, but maybe we want it for this case. I looked for other instances of
this pattern and did not find any more problems.

[viettrungluu, 2014-03-10 20:08:47]

lgtm

[brettw, 2014-03-11 21:15:44]

Committed patchset #8 manually as r256311 (presubmit successful).