Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js

Issue 1877923002: [MD settings] advanced font settings extension link (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review changes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js b/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js
index e698ece59ae4c22de668dfd82a4322a61c0e278a..5f2c9e417f2cf834102ff09f2bb4b1d7a40053c8 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js
+++ b/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js
@@ -35,9 +35,18 @@
Polymer({
is: 'settings-appearance-fonts-page',
- behaviors: [I18nBehavior],
+ behaviors: [I18nBehavior, WebUIListenerBehavior],
properties: {
+ /** @private */
+ advancedExtensionInstalled_: Boolean,
+
+ /** @private */
+ advancedExtensionSublabel_: String,
+
+ /** @private */
+ advancedExtensionUrl_: String,
+
/** @private {!settings.FontsBrowserProxy} */
browserProxy_: Object,
@@ -152,6 +161,10 @@
/** @override */
ready: function() {
+ this.addWebUIListener('advanced-font-settings-installed',
+ this.setAdvancedExtensionInstalled_.bind(this));
+ this.browserProxy_.observeAdvancedFontExtensionAvailable();
+
this.browserProxy_.fetchFontsData().then(
this.setFontsData_.bind(this));
},
@@ -174,8 +187,28 @@
this.minimumFontSizeRange_[this.immediateMinimumSizeIndex_]);
},
+ /** @private */
+ openAdvancedExtension_: function() {
+ if (this.advancedExtensionInstalled_)
+ this.browserProxy_.openAdvancedFontSettings();
+ else
+ window.open(this.advancedExtensionUrl_);
+ },
+
+ /**
+ * @param {boolean} isInstalled Whether the advanced font settings
+ * extension is installed.
+ * @private
+ */
+ setAdvancedExtensionInstalled_: function(isInstalled) {
+ this.advancedExtensionInstalled_ = isInstalled;
+ this.advancedExtensionSublabel_ = this.i18n(isInstalled ?
+ 'openAdvancedFontSettings' : 'requiresWebStoreExtension');
+ },
+
/**
- * @param {!FontsData} response A list of fonts and encodings.
+ * @param {!FontsData} response A list of fonts, encodings and the advanced
+ * font settings extension URL.
* @private
*/
setFontsData_: function(response) {
@@ -199,6 +232,7 @@
});
}
this.$.encoding.menuOptions = encodingMenuOptions;
+ this.advancedExtensionUrl_ = response.extensionUrl;
},
/**

Powered by Google App Engine
This is Rietveld 408576698