Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 1877883002: Fixes for CommandBuffer bot (Closed)

Created:
4 years, 8 months ago by borenet2
Modified:
4 years, 8 months ago
Reviewers:
borenet, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add dm flags and gyp_defines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+681 lines, -1674 lines) Patch
M tools/build_command_buffer.py View 2 chunks +8 lines, -8 lines 0 comments Download
M tools/buildbot_spec.json View 1 125 chunks +385 lines, -1661 lines 0 comments Download
M tools/buildbot_spec.py View 1 2 chunks +5 lines, -0 lines 0 comments Download
M tools/dm_flags.json View 1 1 chunk +273 lines, -0 lines 0 comments Download
M tools/dm_flags.py View 1 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
borenet
4 years, 8 months ago (2016-04-11 17:01:02 UTC) #4
bsalomon
lgtm
4 years, 8 months ago (2016-04-11 17:03:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877883002/20001
4 years, 8 months ago (2016-04-11 17:05:06 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 17:16:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/48b88cc1f6658350d7905e7dca3ba5c53adbba00

Powered by Google App Engine
This is Rietveld 408576698