Issue 1877843002: Disable DataReductionProxyInterceptorTest.TestJobFactoryChaining on Mac

Issue 1877843002: Disable DataReductionProxyInterceptorTest.TestJobFactoryChaining on Mac (Closed)

Created:
4 years, 8 months ago by kjellander_chromium

Modified:
4 years, 8 months ago

Reviewers:
RyanSturm, tbansal1

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable DataReductionProxyInterceptorTest.TestJobFactoryChaining on Mac The test is flaky with failures like: [ RUN ] DataReductionProxyInterceptorTest.TestJobFactoryChaining ../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:167: Failure Value of: interceptor1->request_count() Actual: 2 Expected: 1 ../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:168: Failure Value of: interceptor1->redirect_count() Actual: 1 Expected: 0 ../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:170: Failure Value of: interceptor2->request_count() Actual: 2 Expected: 1 ../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:171: Failure Value of: interceptor2->redirect_count() Actual: 1 Expected: 0 [ FAILED ] DataReductionProxyInterceptorTest.TestJobFactoryChaining (3 ms) BUG=601562 TBR=ryansturm@chromium.org Committed: https://crrev.com/0667717893bbdd895807ff44c5aa9321cd1ae112 Cr-Commit-Position: refs/heads/master@{#386374}

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 10 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877843002/1

4 years, 8 months ago (2016-04-11 12:16:47 UTC) #4

commit-bot: I haz the power

Description was changed from ========== Disable DataReductionProxyInterceptorTest.TestJobFactoryChaining on Mac The test is flaky with failures ...

4 years, 8 months ago (2016-04-11 12:52:19 UTC) #5

Message was sent while issue was closed.

Description was changed from

==========
Disable DataReductionProxyInterceptorTest.TestJobFactoryChaining on Mac

The test is flaky with failures like:
[ RUN      ] DataReductionProxyInterceptorTest.TestJobFactoryChaining
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:167:
Failure
Value of: interceptor1->request_count()
  Actual: 2
Expected: 1
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:168:
Failure
Value of: interceptor1->redirect_count()
  Actual: 1
Expected: 0
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:170:
Failure
Value of: interceptor2->request_count()
  Actual: 2
Expected: 1
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:171:
Failure
Value of: interceptor2->redirect_count()
  Actual: 1
Expected: 0
[  FAILED  ] DataReductionProxyInterceptorTest.TestJobFactoryChaining (3 ms)



BUG=601562
TBR=ryansturm@chromium.org
==========

to

==========
Disable DataReductionProxyInterceptorTest.TestJobFactoryChaining on Mac

The test is flaky with failures like:
[ RUN      ] DataReductionProxyInterceptorTest.TestJobFactoryChaining
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:167:
Failure
Value of: interceptor1->request_count()
  Actual: 2
Expected: 1
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:168:
Failure
Value of: interceptor1->redirect_count()
  Actual: 1
Expected: 0
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:170:
Failure
Value of: interceptor2->request_count()
  Actual: 2
Expected: 1
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:171:
Failure
Value of: interceptor2->redirect_count()
  Actual: 1
Expected: 0
[  FAILED  ] DataReductionProxyInterceptorTest.TestJobFactoryChaining (3 ms)



BUG=601562
TBR=ryansturm@chromium.org
==========

commit-bot: I haz the power

Description was changed from ========== Disable DataReductionProxyInterceptorTest.TestJobFactoryChaining on Mac The test is flaky with failures ...

4 years, 8 months ago (2016-04-11 12:53:37 UTC) #7

Message was sent while issue was closed.

Description was changed from

==========
Disable DataReductionProxyInterceptorTest.TestJobFactoryChaining on Mac

The test is flaky with failures like:
[ RUN      ] DataReductionProxyInterceptorTest.TestJobFactoryChaining
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:167:
Failure
Value of: interceptor1->request_count()
  Actual: 2
Expected: 1
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:168:
Failure
Value of: interceptor1->redirect_count()
  Actual: 1
Expected: 0
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:170:
Failure
Value of: interceptor2->request_count()
  Actual: 2
Expected: 1
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:171:
Failure
Value of: interceptor2->redirect_count()
  Actual: 1
Expected: 0
[  FAILED  ] DataReductionProxyInterceptorTest.TestJobFactoryChaining (3 ms)



BUG=601562
TBR=ryansturm@chromium.org
==========

to

==========
Disable DataReductionProxyInterceptorTest.TestJobFactoryChaining on Mac

The test is flaky with failures like:
[ RUN      ] DataReductionProxyInterceptorTest.TestJobFactoryChaining
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:167:
Failure
Value of: interceptor1->request_count()
  Actual: 2
Expected: 1
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:168:
Failure
Value of: interceptor1->redirect_count()
  Actual: 1
Expected: 0
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:170:
Failure
Value of: interceptor2->request_count()
  Actual: 2
Expected: 1
../../components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc:171:
Failure
Value of: interceptor2->redirect_count()
  Actual: 1
Expected: 0
[  FAILED  ] DataReductionProxyInterceptorTest.TestJobFactoryChaining (3 ms)

BUG=601562
TBR=ryansturm@chromium.org

Committed: https://crrev.com/0667717893bbdd895807ff44c5aa9321cd1ae112
Cr-Commit-Position: refs/heads/master@{#386374}
==========

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/0667717893bbdd895807ff44c5aa9321cd1ae112 Cr-Commit-Position: refs/heads/master@{#386374}

4 years, 8 months ago (2016-04-11 12:53:38 UTC) #8

RyanSturm

4 years, 8 months ago (2016-04-11 18:20:48 UTC) #10

Message was sent while issue was closed.

lgtm as a temporary fix for flakiness until someone investigates, +tbansal1
since I'm not an owner.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages