components/omnibox/browser/autocomplete_match.cc - Issue 1877833002: Optimize shortcuts provider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/autocomplete_match.cc

Issue 1877833002: Optimize shortcuts provider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes after review, round 2 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/browser/autocomplete_match.cc

diff --git a/components/omnibox/browser/autocomplete_match.cc b/components/omnibox/browser/autocomplete_match.cc

index 0af5bf32af2768339ac009903064a7be93348d6d..82a29d196e4e04c29dc2f718d7b99f43b315eded 100644

--- a/components/omnibox/browser/autocomplete_match.cc

+++ b/components/omnibox/browser/autocomplete_match.cc

@@ -272,10 +272,8 @@ bool AutocompleteMatch::MoreRelevant(const AutocompleteMatch& elem1,

// static

bool AutocompleteMatch::DestinationsEqual(const AutocompleteMatch& elem1,

const AutocompleteMatch& elem2) {

- if (elem1.stripped_destination_url.is_empty() &&

- elem2.stripped_destination_url.is_empty())

- return false;

- return elem1.stripped_destination_url == elem2.stripped_destination_url;

+ return !elem1.stripped_destination_url.is_empty() &&

+ (elem1.stripped_destination_url == elem2.stripped_destination_url);

}

// static