components/omnibox/browser/autocomplete_result.h - Issue 1877833002: Optimize shortcuts provider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/autocomplete_result.h

Issue 1877833002: Optimize shortcuts provider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase on master and minor format fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/browser/autocomplete_result.h

diff --git a/components/omnibox/browser/autocomplete_result.h b/components/omnibox/browser/autocomplete_result.h

index 832827b5f9461cf7e264e62b97ae0b0e17f8b5ef..160aa3c58ec2eda765f966472633c9b655596a70 100644

--- a/components/omnibox/browser/autocomplete_result.h

+++ b/components/omnibox/browser/autocomplete_result.h

@@ -126,12 +126,11 @@ class AutocompleteResult {

// Sort |matches| by destination, taking into account demotions based on

// |page_classification| when resolving ties about which of several

- // duplicates to keep. The matches are also deduplicated. If

- // |set_duplicate_matches| is true, the duplicate matches are stored in the

- // |duplicate_matches| vector of the corresponding AutocompleteMatch.

- static void DedupMatchesByDestination(

+ // duplicates to keep. The matches are also deduplicated. Duplicate matches

+ // are stored in the |duplicate_matches| vector of the corresponding

+ // AutocompleteMatch.

+ static void SortAndDedupMatches(

metrics::OmniboxEventProto::PageClassification page_classification,

- bool set_duplicate_matches,

ACMatches* matches);

private: