DescriptionFix incorrect indices for emphasis marks drawing in InlineTextBox::paint
The assertion failure in HarfBuzzShaper is triggered because the TextRun
passed to paintTextWithShadows is replaced with
objectReplacementCharacterTextRun which only has a length of 1.
Previously, we did not have an implementation of emphasis mark
drawing for complex text with HarfBuzz, so instead of running into the
assertion, those paint calls were not doing anything. The indices have
been wrong since the emphasis marks drawing for RenderCombineText
elements was fixed in 7565e3bbdccf98450271 (in 2011). I updated the
test case to be equivalent to the original fuzz testing report and so
that it actually combines text that is marked as combined where no
font with narrow digits exists.
BUG=348682
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168592
Patch Set 1 #Patch Set 2 : Keeping previous FIXME #
Messages
Total messages: 7 (0 generated)
|