Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: src/x64/disasm-x64.cc

Issue 1877823003: Revert of Fix printf formats (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/wasm-result.h ('k') | src/x87/disasm-x87.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x64/disasm-x64.cc
diff --git a/src/x64/disasm-x64.cc b/src/x64/disasm-x64.cc
index ff5ce3b3a3ca9c68a27da81fd619e6a59d278acb..a9532dc3ad9b97f8f238cefa7450b26c002dbed4 100644
--- a/src/x64/disasm-x64.cc
+++ b/src/x64/disasm-x64.cc
@@ -8,7 +8,6 @@
#if V8_TARGET_ARCH_X64
-#include "src/base/compiler-specific.h"
#include "src/base/lazy-instance.h"
#include "src/disasm.h"
@@ -480,7 +479,7 @@
int MemoryFPUInstruction(int escape_opcode, int regop, byte* modrm_start);
int RegisterFPUInstruction(int escape_opcode, byte modrm_byte);
int AVXInstruction(byte* data);
- PRINTF_FORMAT(2, 3) void AppendToBuffer(const char* format, ...);
+ void AppendToBuffer(const char* format, ...);
void UnimplementedInstruction() {
if (abort_on_unimplemented_) {
@@ -619,7 +618,7 @@
value = 0; // Initialize variables on all paths to satisfy the compiler.
count = 0;
}
- AppendToBuffer("%" PRIx64, value);
+ AppendToBuffer("%" V8_PTR_PREFIX "x", value);
return count;
}
@@ -2000,7 +1999,7 @@
if (rex_w()) AppendToBuffer("REX.W ");
AppendToBuffer("%s%c", idesc.mnem, operand_size_code());
} else {
- AppendToBuffer("%s%c", idesc.mnem, operand_size_code());
+ AppendToBuffer("%s", idesc.mnem, operand_size_code());
}
data++;
break;
@@ -2335,7 +2334,9 @@
default:
UNREACHABLE();
}
- AppendToBuffer("test%c rax,0x%" PRIx64, operand_size_code(), value);
+ AppendToBuffer("test%c rax,0x%" V8_PTR_PREFIX "x",
+ operand_size_code(),
+ value);
break;
}
case 0xD1: // fall through
« no previous file with comments | « src/wasm/wasm-result.h ('k') | src/x87/disasm-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698